Update transformer version checks and documentation for lr_scheduler_kwargs workaround#4876
Merged
qgallouedec merged 4 commits intomainfrom Jan 20, 2026
Merged
Update transformer version checks and documentation for lr_scheduler_kwargs workaround#4876qgallouedec merged 4 commits intomainfrom
qgallouedec merged 4 commits intomainfrom
Conversation
…kwargs workaround
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Jan 20, 2026
| @require_torch_accelerator | ||
| def test_training_with_transformers_paged(self, config_name): | ||
| if Version(transformers.__version__) < Version("4.57.0"): | ||
| pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0") |
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I think we should keep the xfail and just update the message.
- We want the test to be marked as xfail if run in a venv with transformers < 4.57.0
Member
Author
There was a problem hiding this comment.
Ah right, it does fail when running with transformers==4.56.2 (minimal version supported). We just don't test it, because this test lives in experimental
qgallouedec
commented
Jan 20, 2026
| def test_training_with_transformers_paged(self, model_name): | ||
| """Test that training works with transformers paged implementation (requires GPU).""" | ||
| if Version(transformers.__version__) < Version("4.57.0"): | ||
| pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0") |
Member
Author
There was a problem hiding this comment.
qgallouedec
requested review from
albertvillanova,
edbeeching,
kashif and
lewtun
albertvillanova
approved these changes
Jan 20, 2026
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks for the updates.
Just a comment below.
| @require_torch_accelerator | ||
| def test_training_with_transformers_paged(self, config_name): | ||
| if Version(transformers.__version__) < Version("4.57.0"): | ||
| pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0") |
Member
There was a problem hiding this comment.
I think we should keep the xfail and just update the message.
- We want the test to be marked as xfail if run in a venv with transformers < 4.57.0
marcandrelarochelle
pushed a commit
to marcandrelarochelle/trl
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.