Use pytest-datadir in CI tests#4836
Merged
albertvillanova merged 3 commits intohuggingface:mainfrom Jan 16, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Jan 16, 2026
marcandrelarochelle
pushed a commit
to marcandrelarochelle/trl
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pytest-datadir in CI tests.
This PR improves the test infrastructure by adding the
pytest-datadirdependency and updates two test cases to use theshared_datadirfixture for accessing test data. This change makes the tests more robust and portable by ensuring test data paths are handled consistently.Test infrastructure improvements:
pytest-datadirto both thetestanddevdependency groups inpyproject.tomlto provide a fixture for managing test data directories.Test case updates:
test_train_with_set_chat_template_from_pathin bothtests/test_reward_trainer.pyandtests/test_sft_trainer.pyto use theshared_datadirfixture instead of a hardcoded path for loadingtemplate.jinja.