cc @jackdingilian
The use of EqualsTester added in 25218e8 is incorrect:
|
new EqualsTester() |
|
.addEqualityGroup( |
|
StructWithSchema.fromProto(structProto.getStructType()), |
|
StructWithSchema.fromProto(structProto.getStructType())) |
|
.addEqualityGroup( |
|
StructWithSchema.fromProto(complexStructProto.getStructType()), |
|
StructWithSchema.fromProto(complexStructProto.getStructType())); |
There needs to be a terminal call to testEquals() for the equals tester to do anything, that assertion is not currently being run.
This issue was found by https://errorprone.info/bugpattern/MissingTestCall
cc @jackdingilian
The use of
EqualsTesteradded in 25218e8 is incorrect:java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/common/TypeTest.java
Lines 123 to 129 in 25218e8
There needs to be a terminal call to
testEquals()for the equals tester to do anything, that assertion is not currently being run.This issue was found by https://errorprone.info/bugpattern/MissingTestCall