tests(bigframes): re-enable some tests blocking the doctest#16806
Draft
chelsea-lin wants to merge 1 commit intomainfrom
Draft
tests(bigframes): re-enable some tests blocking the doctest#16806chelsea-lin wants to merge 1 commit intomainfrom
chelsea-lin wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates doctests and unit tests to align with changes in struct field ordering and simplifies JSON comparison logic using pd.testing.assert_series_equal. However, the removal of check_dtype=False in test_series.py may lead to test failures or flakiness if the dtypes from the BigQuery backend do not perfectly match the pandas defaults.
chelsea-lin
force-pushed
the
main_chelsealin_doctets
branch
from
6a475f4 to
95a2fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal tests 506201379🦕