chore: remove api_id_override from librarian.yaml#16798
Open
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Open
chore: remove api_id_override from librarian.yaml#16798jskeet wants to merge 2 commits intogoogleapis:mainfrom
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
Author
|
@daniel-sanche I believe this one will just be safe to merge. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates API IDs across multiple packages and the central librarian configuration, often replacing generic IDs with more specific service endpoints. However, the refactoring of the system test execution logic in the Spanner noxfile.py introduces several regressions, such as duplicated test execution when using positional arguments, the removal of necessary asyncio configuration flags, and the merging of sync and async test runs. It is recommended to revert the changes to the noxfile and address that refactoring in a separate pull request.
jskeet
force-pushed
the
remove-api-id-override
branch
from
86e24ac to
f3767d8
Compare
parthea
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/librarian#4175