chore: remove issue_tracker_override from librarian.yaml#16792
Open
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Open
chore: remove issue_tracker_override from librarian.yaml#16792jskeet wants to merge 2 commits intogoogleapis:mainfrom
jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
Author
|
@daniel-sanche It looks like this is only used in .repo-metadata.json, not in published documentation, so I think this should be safe to simply merge. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily updates or removes issue tracker metadata across numerous packages in librarian.yaml and .repo-metadata.json files. However, it also includes a refactor of the system test execution logic in packages/google-cloud-spanner/noxfile.py. Feedback indicates that this refactor introduces several regressions, such as omitting the necessary asyncio_mode configuration, merging sync and async test runs which may cause side effects, and removing sanity checks that ensure the Nox session skips gracefully when tests are missing.
jskeet
force-pushed
the
remove-issue-tracker-override
branch
from
57e4c6b to
c95e291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/librarian#5465