Skip to content

Streaming: add pep8 / pylint goodness#1210

Merged
tseaver merged 17 commits intogoogleapis:masterfrom
tseaver:streaming-pep8_pylint
Nov 19, 2015
Merged

Streaming: add pep8 / pylint goodness#1210
tseaver merged 17 commits intogoogleapis:masterfrom
tseaver:streaming-pep8_pylint

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Oct 29, 2015

Uses #1209 as a base.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2015
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Nov 19, 2015

@dhermes rebased after merge of #1209.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Nov 19, 2015

Theres a bit more than PEP8 changes in "Get 'pep8' working on 'gcloud/streaming'." (e.g. dropping request = _Request() and using self.URL in test_transfer.py). No worries though, just an observation, the commit is all good.

Comment thread gcloud/streaming/exceptions.py Outdated

This comment was marked as spam.

This comment was marked as spam.

Comment thread gcloud/streaming/transfer.py Outdated

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Nov 19, 2015

Finished review

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Nov 19, 2015

LGTM

tseaver added a commit that referenced this pull request Nov 19, 2015
Streaming: add pep8 / pylint goodness
@tseaver tseaver merged commit 46d8253 into googleapis:master Nov 19, 2015
@tseaver tseaver deleted the streaming-pep8_pylint branch November 19, 2015 18:00
parthea added a commit that referenced this pull request Nov 24, 2025
* fix: fix snippet region tags

* chore: delete obsolete files

* chore: delete old files

Co-authored-by: Dov Shlachter <dovs@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
* chore: update systest creds

* chore: fix unit test
parthea pushed a commit that referenced this pull request Mar 9, 2026
* build(python): fix `docs` and `docfx` builds

Source-Link: googleapis/synthtool@fac8444
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa

* apply googleapis/synthtool#1916

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Cathy Ouyang <cathyo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants