-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add constraints files for ads templates #16371
Copy link
Copy link
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
The ads templates are missing the the testing folder which includes constraints files.
As an example, see
https://github.com/googleapis/gapic-generator-python/blob/46f17900204ba10035917b3d744f52556d6061ea/gapic/templates/testing/constraints-3.7.txt.j2#L1-L18
These constraints files are used to run tests against the minimum version of dependencies which are defined in setup.py:
https://github.com/googleapis/gapic-generator-python/blob/46f17900204ba10035917b3d744f52556d6061ea/gapic/ads-templates/setup.py.j2#L19-L33
We also need to change the code in
noxfile.pyfrom:https://github.com/googleapis/gapic-generator-python/blob/812abceeb68d86f3902974aaeef8a58cfd6e7515/noxfile.py#L112-L125
to