Skip to content

Treat RESOURCE_EXHAUSTED with retry information as aborted.#2645

Merged
vkedia merged 3 commits intogoogleapis:masterfrom
mairbek:resourceex
Jan 9, 2018
Merged

Treat RESOURCE_EXHAUSTED with retry information as aborted.#2645
vkedia merged 3 commits intogoogleapis:masterfrom
mairbek:resourceex

Conversation

@mairbek
Copy link
Copy Markdown

@mairbek mairbek commented Nov 21, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2017
@vkedia vkedia self-requested a review November 27, 2017 21:46
vkedia
vkedia reviewed Nov 27, 2017
View reviewed changes
Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.
*/
public static long extractRetryDelay(Throwable cause) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.
*/
public static long extractRetryDelay(Throwable cause) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated

/**
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbortedException.java
/**
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.
*/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java Outdated
delay = ((AbortedException) e).getRetryDelayInMillis();
}
long delay = SpannerException.extractRetryDelay(e.getCause());
if (e.getErrorCode() == ErrorCode.ABORTED || (e.getErrorCode() ==

This comment was marked as spam.

Sign in to view

mairbek
mairbek commented Nov 28, 2017
View reviewed changes
Copy link
Copy Markdown
Author

@mairbek mairbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbortedException.java
/**
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.
*/

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated

/**
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.
*/
public static long extractRetryDelay(Throwable cause) {

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any
* retry delay. In that case, clients should fall back to a locally computed retry delay.
*/
public static long extractRetryDelay(Throwable cause) {

This comment was marked as spam.

Sign in to view

vkedia
vkedia reviewed Dec 20, 2017
View reviewed changes
Copy link
Copy Markdown

@vkedia vkedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java Outdated
}

/**
* Return the retry delay for transaction in milliseconds. Return -1 if this does not specify any

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerExceptionFactoryTest.java
trailers.put(key, retryInfo);
SpannerException e =
SpannerExceptionFactory.newSpannerException(new StatusRuntimeException(status, trailers));
assertThat(e.isRetryable()).isTrue();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@vkedia vkedia mentioned this pull request Dec 21, 2017
Closed
@vkedia vkedia merged commit a3144a0 into googleapis:master Jan 9, 2018
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@release-please @cloud-java-bot
chore(main): release 3.9.2 (#2645)
5dc24c2 
* chore(main): release 3.9.2

* chore: generate libraries at Thu Sep 26 15:09:07 UTC 2024

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@JoeWang1127
chore: do not generate pr description if two commits are same (#2645)
3229a8e 
In this PR:
- Do not generate pr_description.txt if googleapis commit is the same in
baseline config and current config.
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@sydney-munro
test: Turn DirectPath quickstart test back on and fix abandoned stora…
f6bbd36 
…ge instance in GRPC test (#2645)

* test: Fix storage closure

* test: turn directpath sample test back on

* use storage options instead of storage to avoid the need to close storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

1 more reviewer

@vkedia vkedia vkedia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mairbek @vkedia @googlebot