Skip to content

Fixing doc on Publisher/Subscriber about credentials #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettjonesgoogle merged 1 commit into from
Apr 28, 2017
Merged

Fixing doc on Publisher/Subscriber about credentials #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@
* <li>Retries: such as the maximum duration of retries for a failing batch of messages.
* </ul>
*
* <p>If no credentials are provided, the {@link Publisher} will use application default credentials
* through {@link GoogleCredentials#getApplicationDefault}.
* <p>{@link Publisher} will use the credentials set on the channel, which uses
* application default credentials through {@link GoogleCredentials#getApplicationDefault}
* by default.
*/
public class Publisher {
private static final Logger logger = Logger.getLogger(Publisher.class.getName());
Expand Down
5 changes: 3 additions & 2 deletions google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@
* in memory before the receiver either ack or nack them.
* </ul>
*
* <p>If no credentials are provided, the {@link Subscriber} will use application default
* credentials through {@link GoogleCredentials#getApplicationDefault}.
* <p>{@link Subscriber} will use the credentials set on the channel, which uses
* application default credentials through {@link GoogleCredentials#getApplicationDefault}
* by default.
*/
public class Subscriber extends AbstractApiService {
private static final int THREADS_PER_CHANNEL = 5;
Expand Down