Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
import com.google.cloud.RestorableState;
import com.google.cloud.RetryHelper;
import com.google.cloud.WriteChannel;
import com.google.common.base.MoreObjects;

import java.util.List;
import java.util.Objects;
import java.util.concurrent.Callable;

Expand Down Expand Up @@ -149,8 +149,10 @@ public boolean equals(Object obj) {
}

@Override
protected MoreObjects.ToStringHelper toStringHelper() {
return super.toStringHelper().add("job", job);
protected List<ValueHolder> toStringHelper() {
List<ValueHolder> valueList = super.toStringHelper();
valueList.add(ValueHolder.create("job", job));
return valueList;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@

import com.google.cloud.storage.Acl;
import com.google.common.base.Optional;
import com.google.common.collect.ImmutableMap;

import java.nio.file.attribute.BasicFileAttributes;
import java.util.List;
import java.util.Map;

/**
* Interface for attributes on a Cloud Storage file or pseudo-directory.
Expand Down Expand Up @@ -75,5 +75,5 @@ public interface CloudStorageFileAttributes extends BasicFileAttributes {
*
* @see "https://developers.google.com/storage/docs/reference-headers#contentdisposition"
*/
ImmutableMap<String, String> userMetadata();
Map<String, String> userMetadata();
}
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public final class CloudStorageFileSystem extends FileSystem {
public static final String BASIC_VIEW = "basic";
public static final int BLOCK_SIZE_DEFAULT = 2 * 1024 * 1024;
public static final FileTime FILE_TIME_UNKNOWN = FileTime.fromMillis(0);
public static final ImmutableSet<String> SUPPORTED_VIEWS = ImmutableSet.of(BASIC_VIEW, GCS_VIEW);
public static final Set<String> SUPPORTED_VIEWS = ImmutableSet.of(BASIC_VIEW, GCS_VIEW);

private final CloudStorageFileSystemProvider provider;
private final String bucket;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@

package com.google.cloud;

import com.google.common.base.MoreObjects;

import java.io.IOException;
import java.io.Serializable;
import java.nio.ByteBuffer;
import java.nio.channels.ClosedChannelException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Objects;

/**
Expand Down Expand Up @@ -295,17 +295,54 @@ public boolean equals(Object obj) {
&& this.chunkSize == other.chunkSize;
}

protected MoreObjects.ToStringHelper toStringHelper() {
return MoreObjects.toStringHelper(this)
.add("entity", entity)
.add("uploadId", uploadId)
.add("position", position)
.add("isOpen", isOpen);
protected static final class ValueHolder {
final String name;
final Object value;

private ValueHolder(String name, Object value) {
this.name = name;
this.value = value;
}

public static ValueHolder create(String name, Object value) {
return new ValueHolder(name, value);
}

@Override
public String toString() {
String result = name + "=";
if (value != null && value.getClass().isArray()) {
Object[] objectArray = new Object[]{value};
String arrayString = Arrays.deepToString(objectArray);
result += arrayString.substring(1, arrayString.length() - 1);
} else {
result += value;
}
return result;
}
}

protected List<ValueHolder> toStringHelper() {
List<ValueHolder> valueList = new ArrayList<>();
valueList.add(ValueHolder.create("entity", entity));
valueList.add(ValueHolder.create("uploadId", uploadId));
valueList.add(ValueHolder.create("position", String.valueOf(position)));
valueList.add(ValueHolder.create("isOpen", String.valueOf(isOpen)));
return valueList;
}

@Override
public String toString() {
return toStringHelper().toString();
StringBuilder builder = new StringBuilder();
builder.append(getClass().getSimpleName())
.append('{');
String nextSeparator = "";
for (ValueHolder valueHolder : toStringHelper()) {
builder.append(nextSeparator).append(valueHolder);
nextSeparator = ", ";
}
builder.append('}');
return builder.toString();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import static com.google.common.base.Preconditions.checkNotNull;

import com.google.api.core.ApiFunction;
import com.google.common.base.Function;
import com.google.common.base.MoreObjects;
import com.google.common.collect.Iterables;
Expand All @@ -37,9 +38,9 @@
public class MonitoredResourceDescriptor implements Serializable {

private static final long serialVersionUID = -3702077512777687441L;
public static final Function<com.google.api.MonitoredResourceDescriptor,
public static final ApiFunction<com.google.api.MonitoredResourceDescriptor,
MonitoredResourceDescriptor> FROM_PB_FUNCTION =
new Function<com.google.api.MonitoredResourceDescriptor, MonitoredResourceDescriptor>() {
new ApiFunction<com.google.api.MonitoredResourceDescriptor, MonitoredResourceDescriptor>() {
@Override
public MonitoredResourceDescriptor apply(
com.google.api.MonitoredResourceDescriptor pb) {
Expand Down
23 changes: 17 additions & 6 deletions google-cloud-core/src/main/java/com/google/cloud/Policy.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull;

import com.google.api.core.ApiFunction;
import com.google.common.base.Function;
import com.google.common.base.MoreObjects;
import com.google.common.collect.ImmutableMap;
Expand Down Expand Up @@ -57,15 +58,15 @@ public final class Policy implements Serializable {

public abstract static class Marshaller<T> {

protected static final Function<String, Identity> IDENTITY_VALUE_OF_FUNCTION =
new Function<String, Identity>() {
protected static final ApiFunction<String, Identity> IDENTITY_VALUE_OF_FUNCTION =
new ApiFunction<String, Identity>() {
@Override
public Identity apply(String identityPb) {
return Identity.valueOf(identityPb);
}
};
protected static final Function<Identity, String> IDENTITY_STR_VALUE_FUNCTION =
new Function<Identity, String>() {
protected static final ApiFunction<Identity, String> IDENTITY_STR_VALUE_FUNCTION =
new ApiFunction<Identity, String>() {
@Override
public String apply(Identity identity) {
return identity.strValue();
Expand All @@ -85,7 +86,12 @@ protected Policy fromPb(com.google.iam.v1.Policy policyPb) {
for (com.google.iam.v1.Binding bindingPb : policyPb.getBindingsList()) {
bindings.put(Role.of(bindingPb.getRole()),
ImmutableSet.copyOf(
Lists.transform(bindingPb.getMembersList(), IDENTITY_VALUE_OF_FUNCTION)));
Lists.transform(bindingPb.getMembersList(), new Function<String, Identity>() {
@Override
public Identity apply(String s) {
return IDENTITY_VALUE_OF_FUNCTION.apply(s);
}
})));
}
return newBuilder()
.setBindings(bindings)
Expand All @@ -103,7 +109,12 @@ protected com.google.iam.v1.Policy toPb(Policy policy) {
com.google.iam.v1.Binding.Builder bindingBuilder = com.google.iam.v1.Binding.newBuilder();
bindingBuilder.setRole(binding.getKey().getValue());
bindingBuilder.addAllMembers(
Lists.transform(new ArrayList<>(binding.getValue()), IDENTITY_STR_VALUE_FUNCTION));
Lists.transform(new ArrayList<>(binding.getValue()), new Function<Identity, String>() {
@Override
public String apply(Identity identity) {
return IDENTITY_STR_VALUE_FUNCTION.apply(identity);
}
}));
bindingPbList.add(bindingBuilder.build());
}
policyBuilder.addAllBindings(bindingPbList);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ public List<String> getDistinctOn() {
/**
* Returns the order by clause for this query.
*/
public ImmutableList<OrderBy> getOrderBy() {
public List<OrderBy> getOrderBy() {
return orderBy;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -120,7 +121,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -155,7 +156,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -110,7 +111,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -156,7 +157,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -176,7 +177,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,13 @@ public AsyncPage<MonitoredResourceDescriptor> apply(
listDescriptorsResponse.getResourceDescriptorsList() == null
? ImmutableList.<MonitoredResourceDescriptor>of()
: Lists.transform(listDescriptorsResponse.getResourceDescriptorsList(),
MonitoredResourceDescriptor.FROM_PB_FUNCTION);
new Function<com.google.api.MonitoredResourceDescriptor, MonitoredResourceDescriptor>() {
@Override
public MonitoredResourceDescriptor apply(
com.google.api.MonitoredResourceDescriptor monitoredResourceDescriptor) {
return MonitoredResourceDescriptor.FROM_PB_FUNCTION.apply(monitoredResourceDescriptor);
}
});
String cursor = listDescriptorsResponse.getNextPageToken().equals("") ? null
: listDescriptorsResponse.getNextPageToken();
return new AsyncPageImpl<>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -176,7 +177,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
import io.grpc.Status;
import java.io.IOException;
import java.util.Collection;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -209,7 +210,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -182,7 +183,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -197,7 +198,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import com.google.protobuf.ExperimentalApi;
import io.grpc.Status;
import java.io.IOException;
import java.util.List;
import javax.annotation.Generated;
import org.joda.time.Duration;

Expand Down Expand Up @@ -261,7 +262,7 @@ public static String getDefaultEndpoint() {
}

/** Returns the default service scopes. */
public static ImmutableList<String> getDefaultServiceScopes() {
public static List<String> getDefaultServiceScopes() {
return DEFAULT_SERVICE_SCOPES;
}

Expand Down
Loading