Skip to content

Make SSLHandShakeException retryable #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinfan merged 1 commit into from
Apr 19, 2017
Merged

Make SSLHandShakeException retryable #1938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google-cloud-core/src/main/java/com/google/cloud/BaseServiceException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@
import java.io.Serializable;
import java.net.SocketException;
import java.net.SocketTimeoutException;
import java.security.cert.CertificateException;
import java.util.Collections;
import java.util.Objects;
import java.util.Set;
import javax.net.ssl.SSLHandshakeException;

/**
* Base class for all service exceptions.
Expand Down Expand Up @@ -203,6 +205,8 @@ protected boolean isRetryable(boolean idempotent, Error error) {
protected boolean isRetryable(boolean idempotent, IOException exception) {
boolean exceptionIsRetryable = exception instanceof SocketTimeoutException
|| exception instanceof SocketException
|| (exception instanceof SSLHandshakeException
&& !(exception.getCause() instanceof CertificateException))
|| "insufficient data written".equals(exception.getMessage());
return idempotent && exceptionIsRetryable;
}
Expand Down