Skip to content

POSC support for Storage#1670

Merged
shinfan merged 9 commits intogoogleapis:masterfrom
shinfan:master
Mar 7, 2017
Merged

POSC support for Storage#1670
shinfan merged 9 commits intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Copy Markdown
Contributor

@shinfan shinfan commented Feb 28, 2017 •
edited
Loading

Fixes: #1602

Tests: Unit tests, Integration tests
cc @omaray

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2017
@shinfan shinfan added the api: storage Issues related to the Cloud Storage API. label Feb 28, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 28, 2017

Coverage Status

Changes Unknown when pulling 37f08e9 on shinfan:master into ** on GoogleCloudPlatform:master**.

michaelbausor
michaelbausor reviewed Mar 2, 2017
View reviewed changes
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java Outdated

abstract Builder setCustomerEncryption(CustomerEncryption customerEncryption);


This comment was marked as spam.

Sign in to view

Comment thread google-cloud-storage/src/test/java/com/google/cloud/storage/BlobInfoTest.java Outdated
private static final String KEY_SHA256 = "keySha";
private static final CustomerEncryption CUSTOMER_ENCRYPTION =
new CustomerEncryption(ENCRYPTION_ALGORITHM, KEY_SHA256);
private static final String STORAGE_CLASS = "COLDLINE";

This comment was marked as spam.

Sign in to view

@shinfan shinfan force-pushed the master branch 2 times, most recently from 7840605 to 37f08e9 Compare March 2, 2017 22:37
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2017

Coverage Status

Coverage increased (+0.02%) to 81.127% when pulling 37f08e9 on shinfan:master into a47d5a0 on GoogleCloudPlatform:master.

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Mar 3, 2017

@michaelbausor PTAL

michaelbausor
michaelbausor reviewed Mar 3, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java Outdated
/**
* String constants for the names of the storage classes.
*/
public class StorageClass {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Mar 3, 2017

@garrettjonesgoogle PTAL

michaelbausor
michaelbausor reviewed Mar 3, 2017
View reviewed changes
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java
* Enums for the storage classes.
* See https://cloud.google.com/storage/docs/storage-classes for details.
*/
public enum StorageClass {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 3, 2017
View reviewed changes
Comment thread ...cloud-examples/src/main/java/com/google/cloud/examples/storage/snippets/StorageSnippets.java
Bucket bucket = storage.create(BucketInfo.newBuilder(bucketName)
// See here for possible values: http://g.co/cloud/storage/docs/storage-classes
.setStorageClass("COLDLINE")
.setStorageClass(StorageClass.COLDLINE)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
* <a href="https://cloud.google.com/storage/docs/storage-classes">here</a>.
*/
public abstract Builder setStorageClass(String storageClass);
public abstract Builder setStorageClass(StorageClass storageClass);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated
*/
@Deprecated
public abstract Builder storageClass(String storageClass);
public abstract Builder storageClass(StorageClass storageClass);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java Outdated
@@ -0,0 +1,48 @@
/*
* Copyright 2015 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/Bucket.java

@Override
public Builder setStorageClass(String storageClass) {
public Builder setStorageClass(StorageClass storageClass) {

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 4, 2017

Coverage Status

Coverage increased (+0.09%) to 81.202% when pulling b3fc31d on shinfan:master into a47d5a0 on GoogleCloudPlatform:master.

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Mar 7, 2017

@garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Mar 7, 2017

LGTM

@shinfan shinfan merged commit 007f340 into googleapis:master Mar 7, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 7, 2017

Coverage Status

Coverage decreased (-0.0001%) to 81.437% when pulling 59499dc on shinfan:master into 5cbbbae on GoogleCloudPlatform:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 8, 2017

Coverage Status

Changes Unknown when pulling 59499dc on shinfan:master into ** on GoogleCloudPlatform:master**.

rybosome pushed a commit to rybosome/google-cloud-java that referenced this pull request Mar 9, 2017
@shinfan @rybosome
POSC support for Storage (googleapis#1670)
339f172
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@cloud-java-bot
chore: Update generation configuration at Fri Aug 2 02:14:46 UTC 2024 (…
e3c6d13 
…#1670)

* chore: Update generation configuration at Thu Aug  1 02:18:43 UTC 2024

* chore: Update generation configuration at Fri Aug  2 02:14:46 UTC 2024
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@renovate-bot
chore(deps): update dependency com.google.http-client:google-http-cli…
96a5ad8 
…ent-bom to v1.46.1 (#1670)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@cloud-java-bot
chore: Update generation configuration at Fri Aug 2 02:14:46 UTC 2024 (…
a6dbdee 
…googleapis#1670)

* chore: Update generation configuration at Thu Aug  1 02:18:43 UTC 2024

* chore: Update generation configuration at Fri Aug  2 02:14:46 UTC 2024
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@renovate-bot
chore(deps): update dependency com.google.http-client:google-http-cli…
0e8fcf5 
…ent-bom to v1.46.1 (#1670)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 2.20.1 (googleapis#1670)
fcf19ab 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
4ff18b0 
…o v1.123.19 (#1670)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-pubsub](https://togithub.com/googleapis/java-pubsub) | `1.123.18` -> `1.123.19` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:google-cloud-pubsub/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:google-cloud-pubsub/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:google-cloud-pubsub/1.123.18/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:google-cloud-pubsub/1.123.18/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-pubsub (com.google.cloud:google-cloud-pubsub)</summary>

### [`v1.123.19`](https://togithub.com/googleapis/java-pubsub/blob/HEAD/CHANGELOG.md#112319-2023-07-25)

[Compare Source](https://togithub.com/googleapis/java-pubsub/compare/v1.123.18...v1.123.19)

##### Dependencies

-   Update dependency com.google.cloud:google-cloud-bigquery to v2.30.1 ([#&#8203;1656](https://togithub.com/googleapis/java-pubsub/issues/1656)) ([4fe4bc4](https://togithub.com/googleapis/java-pubsub/commit/4fe4bc49d82753e3e185f0a2c4694d80e48808f7))
-   Update dependency com.google.cloud:google-cloud-core to v2.21.1 ([#&#8203;1662](https://togithub.com/googleapis/java-pubsub/issues/1662)) ([e10292c](https://togithub.com/googleapis/java-pubsub/commit/e10292c16f24870a91584f716545ff210302a7bc))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.1 ([#&#8203;1663](https://togithub.com/googleapis/java-pubsub/issues/1663)) ([50f4ff1](https://togithub.com/googleapis/java-pubsub/commit/50f4ff10140699a02d1ec550b05ff6d1aa39c762))
-   Update dependency org.junit.vintage:junit-vintage-engine to v5.10.0 ([#&#8203;1666](https://togithub.com/googleapis/java-pubsub/issues/1666)) ([d8712a3](https://togithub.com/googleapis/java-pubsub/commit/d8712a31459b8f9497dff7a866c8a8795ca60af9))
-   Update dependency org.xerial.snappy:snappy-java to v1.1.10.3 ([#&#8203;1665](https://togithub.com/googleapis/java-pubsub/issues/1665)) ([ad1c515](https://togithub.com/googleapis/java-pubsub/commit/ad1c5157eadc4bf2d43b7dc332ac4150d732912d))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-pubsub).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
e4948fb 
…o v1.123.19 (#1670)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-pubsub](https://togithub.com/googleapis/java-pubsub) | `1.123.18` -> `1.123.19` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:google-cloud-pubsub/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:google-cloud-pubsub/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:google-cloud-pubsub/1.123.18/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:google-cloud-pubsub/1.123.18/1.123.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-pubsub (com.google.cloud:google-cloud-pubsub)</summary>

### [`v1.123.19`](https://togithub.com/googleapis/java-pubsub/blob/HEAD/CHANGELOG.md#112319-2023-07-25)

[Compare Source](https://togithub.com/googleapis/java-pubsub/compare/v1.123.18...v1.123.19)

##### Dependencies

-   Update dependency com.google.cloud:google-cloud-bigquery to v2.30.1 ([#&#8203;1656](https://togithub.com/googleapis/java-pubsub/issues/1656)) ([15d7ffe](https://togithub.com/googleapis/java-pubsub/commit/15d7ffe46df78ec400839e601864bc955c5ea20e))
-   Update dependency com.google.cloud:google-cloud-core to v2.21.1 ([#&#8203;1662](https://togithub.com/googleapis/java-pubsub/issues/1662)) ([5d06218](https://togithub.com/googleapis/java-pubsub/commit/5d062187ed1fd463d122491a4b4747383c67faca))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.1 ([#&#8203;1663](https://togithub.com/googleapis/java-pubsub/issues/1663)) ([f677004](https://togithub.com/googleapis/java-pubsub/commit/f67700468e3975665f8544c90663714f73dd3471))
-   Update dependency org.junit.vintage:junit-vintage-engine to v5.10.0 ([#&#8203;1666](https://togithub.com/googleapis/java-pubsub/issues/1666)) ([47f8a34](https://togithub.com/googleapis/java-pubsub/commit/47f8a3465a81228aebe02486c5edffa3f89ac59f))
-   Update dependency org.xerial.snappy:snappy-java to v1.1.10.3 ([#&#8203;1665](https://togithub.com/googleapis/java-pubsub/issues/1665)) ([c557254](https://togithub.com/googleapis/java-pubsub/commit/c55725449952461d975ef36e3bf0dd7f51bab64f))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-pubsub).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jskeet jskeet Awaiting requested review from jskeet

@tswast tswast Awaiting requested review from tswast

2 more reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@michaelbausor michaelbausor michaelbausor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shinfan @coveralls @garrettjonesgoogle @michaelbausor @googlebot