getNextPageToken returns Object, setPageToken taking String

[waprin]

This is using the Monitoring VTK. This causes a lot of ugly code since casting a null to a String is an exception.

[waprin]

lesv says it blocks release

[garrettjonesgoogle]

Monitoring isn't part of the 4 GA APIs, so this issue shouldn't block GA.

[garrettjonesgoogle]

@lesv since the marking of this issue as release-blocking involves a second-hand report from a statement by you, could you clarify here?

[lesv]

Yea - it doesn't block GA - it should, however get fixed at some point.

(I was at his desk when it wrote this up.) (I thought this tag was block next release of Monitoring)

[garrettjonesgoogle]

It's "future release blocking" I guess, but to make the next release easier to track, I removed the label.

[waprin]

It's also not quite as bad as I had thought since the Object returned on the final page isn't null, it's just the empty String, so it's safe to cast to String. Still a pretty weird API inconsistency.

[michaelbausor]

Fixed in googleapis/gapic-generator#1139 and #1894