Change type of HookDelivery.InstallationID to Int64.#2235
Change type of HookDelivery.InstallationID to Int64.#2235gmlewis merged 2 commits intogoogle:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2235 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 113 113
Lines 10156 10156
=======================================
Hits 9932 9932
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
gmlewis
left a comment
There was a problem hiding this comment.
I'm wondering why these fields are pointers but don't have omitempty?
gmlewis
left a comment
There was a problem hiding this comment.
I've looked through the code and can't find an explanation for why the fields in the HookDelivery do not have an omitempty even though they are all references.
So while we are breaking the API, please go ahead and add omitempty to all the fields in lines 20-30. Thank you!
|
@gmlewis yeah it looks like it was added on the |
|
Is there anyone else who can provide review? Doesn't seem like @wesleimp is very active any more. |
|
Thank you, @Parker77 ! |
Resolves #2234