Skip to content

fix(models): pass NOT_GIVEN instead of None for system instruction in AnthropicLlm #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmolg1997 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

fix(models): pass NOT_GIVEN instead of None for system instruction in AnthropicLlm #5337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/google/adk/models/anthropic_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,16 @@ async def generate_content_async(
else NOT_GIVEN
)

system = (
llm_request.config.system_instruction
if llm_request.config and llm_request.config.system_instruction
else NOT_GIVEN
)

if not stream:
message = await self._anthropic_client.messages.create(
model=model_to_use,
system=llm_request.config.system_instruction,
system=system,
messages=messages,
tools=tools,
tool_choice=tool_choice,
Expand All @@ -431,9 +437,14 @@ async def _generate_content_streaming(
a final aggregated LlmResponse with all content.
"""
model_to_use = self._resolve_model_name(llm_request.model)
system = (
llm_request.config.system_instruction
if llm_request.config and llm_request.config.system_instruction
else NOT_GIVEN
)
raw_stream = await self._anthropic_client.messages.create(
model=model_to_use,
system=llm_request.config.system_instruction,
system=system,
messages=messages,
tools=tools,
tool_choice=tool_choice,
Expand Down