fix: install fish completions to vendor directory#2859
Open
Legimity wants to merge 1 commit into
Open
Conversation
c176b13 to
03494a1
Compare
Author
|
Thanks! I removed the changelog changes and kept this PR focused on the nfpm Fish completion path update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2850.
This updates the Linux package metadata so the Fish completion file is installed to Fish vendor completions:
/usr/share/fish/vendor_completions.d/task.fishThe previous package path used
/usr/share/fish/completions/task.fish, which is intended for completions shipped with Fish itself.Validation run:
ruby -e 'require "yaml"; YAML.load_file(".goreleaser.yml"); YAML.load_file(".goreleaser-pr.yml"); YAML.load_file(".goreleaser-nightly.yml"); puts "yaml ok"'ruby -e 'require "yaml"; y=YAML.load_file(".goreleaser.yml"); fish=y.fetch("nfpms").first.fetch("contents").find{|e| e["src"]=="completion/fish/task.fish"}; abort "bad fish dst" unless fish["dst"]=="/usr/share/fish/vendor_completions.d/task.fish"; puts "fish nfpm dst ok"'git diff --checkNot run:
goreleaser check --config .goreleaser.yml:goreleaseris not installed locally.go test ./...: local Go is1.24.3, while this repo currently requires1.25.10; automatic toolchain download timed out in my environment.AI assistance disclosure: I used AI assistance to draft and verify this patch, then reviewed the diff and validation output before submitting.