Skip to content

fix: install fish completions to vendor directory#2859

Open
Legimity wants to merge 1 commit into
go-task:mainfrom
Legimity:fix/2850-fish-vendor-completions
Open

fix: install fish completions to vendor directory#2859
Legimity wants to merge 1 commit into
go-task:mainfrom
Legimity:fix/2850-fish-vendor-completions

Conversation

@Legimity
Copy link
Copy Markdown

@Legimity Legimity commented May 27, 2026

Fixes #2850.

This updates the Linux package metadata so the Fish completion file is installed to Fish vendor completions:

  • /usr/share/fish/vendor_completions.d/task.fish

The previous package path used /usr/share/fish/completions/task.fish, which is intended for completions shipped with Fish itself.

Validation run:

  • ruby -e 'require "yaml"; YAML.load_file(".goreleaser.yml"); YAML.load_file(".goreleaser-pr.yml"); YAML.load_file(".goreleaser-nightly.yml"); puts "yaml ok"'
  • ruby -e 'require "yaml"; y=YAML.load_file(".goreleaser.yml"); fish=y.fetch("nfpms").first.fetch("contents").find{|e| e["src"]=="completion/fish/task.fish"}; abort "bad fish dst" unless fish["dst"]=="/usr/share/fish/vendor_completions.d/task.fish"; puts "fish nfpm dst ok"'
  • git diff --check

Not run:

  • goreleaser check --config .goreleaser.yml: goreleaser is not installed locally.
  • go test ./...: local Go is 1.24.3, while this repo currently requires 1.25.10; automatic toolchain download timed out in my environment.

AI assistance disclosure: I used AI assistance to draft and verify this patch, then reviewed the diff and validation output before submitting.

@Legimity Legimity marked this pull request as ready for review May 27, 2026 13:47
Copy link
Copy Markdown
Contributor

@trulede trulede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Legimity Thanks, looks good.

You should remove the changelog stuff. That gets done by "other means".

@Legimity Legimity force-pushed the fix/2850-fish-vendor-completions branch from c176b13 to 03494a1 Compare May 28, 2026 00:34
@Legimity
Copy link
Copy Markdown
Author

Thanks! I removed the changelog changes and kept this PR focused on the nfpm Fish completion path update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fish completions should be installed to /usr/share/fish/vendor-completions.d

2 participants