Missing push rules properties#1319
Merged
jmini merged 4 commits intogitlab4j:mainfrom May 2, 2026
Merged
Conversation
jmini
approved these changes
May 2, 2026
Collaborator
jmini
left a comment
jmini
left a comment
There was a problem hiding this comment.
Looks good to me. I would like the corresponding example json file updated
jmini
reviewed
May 2, 2026
| .withParam("max_file_size", pushRule.getMaxFileSize()) | ||
| .withParam("commit_committer_check", pushRule.getCommitCommitterCheck()) | ||
| .withParam("reject_unsigned_commits", pushRule.getRejectUnsignedCommits()); | ||
| .withParam("commit_committer_name_check", pushRule.getCommitCommitterNameChack()) |
jmini
reviewed
May 2, 2026
jmini
reviewed
May 2, 2026
jmini
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using gitlab4j with Gilab 18.6 and it seems now, properties : commit_committer_name_check and reject_non_dco_commits are mandatory when creating or updating push rules.