Skip to content

Make Den the only Den and make him always have a flower#130

Closed
yarikoptic wants to merge 1 commit intogithub:mainfrom
yarikoptic:enh-mailmap
Closed

Make Den the only Den and make him always have a flower#130
yarikoptic wants to merge 1 commit intogithub:mainfrom
yarikoptic:enh-mailmap

Conversation

@yarikoptic
Copy link
Copy Markdown

With this change we get

❯ git shortlog -sn
    39  Den Delimarsky 🌺
    ...

whenever on master we have

❯ git shortlog -sn
    20  Den Delimarsky
    19  Den Delimarsky 🌺
    ...

With this change we get

    ❯ git shortlog -sn
        39  Den Delimarsky 🌺
        ...

whenever on master we have

    ❯ git shortlog -sn
        20  Den Delimarsky
        19  Den Delimarsky 🌺
        ...

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
Copilot AI review requested due to automatic review settings September 10, 2025 02:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates Git commit attribution by adding a .mailmap file to unify all commits under a single author identity with consistent formatting. This ensures that git shortlog displays all commits from Den Delimarsky under one name with the flower emoji.

  • Adds .mailmap file to standardize author name formatting across all commits
  • Maps all Den Delimarsky commits to use the flower emoji variant consistently
Comments suppressed due to low confidence (1)

.mailmap:2

  • The .mailmap entry is incomplete. It should specify which email addresses or names to map from. The current format only defines the target identity but doesn't specify what to map to it. Consider adding the source email/name patterns, for example: Den Delimarsky 🌺 <email@domain.com> <old-email@domain.com> or Den Delimarsky 🌺 <email@domain.com> Den Delimarsky.
Den Delimarsky 🌺 <53200638+localden@users.noreply.github.com>


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@localden
Copy link
Copy Markdown
Contributor

localden commented Sep 10, 2025

Thank you @yarikoptic for this very important call-out 🤣 I should, indeed, always have a flower next to my name. That being said, let's not introduce this particular metadata piece in the code base for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants