Skip to content

Java: Threat Models#13506

Merged
michaelnebel merged 3 commits intogithub:mainfrom
michaelnebel:java/threatmodels
Aug 7, 2023
Merged

Java: Threat Models#13506
michaelnebel merged 3 commits intogithub:mainfrom
michaelnebel:java/threatmodels

Conversation

@michaelnebel
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel commented Jun 20, 2023

This PR covers the very initial work on supported threat models as describes in: https://github.com/github/code-scanning/pull/10356

In this PR we introduce some of the extensible predicates (and small helper predicates) needed to glue together the work made by CodeQL Experiences team and the CodeQL static languages teams.
The CodeQL experiences team will work on populating the extensible supportedThreatModel predicate with tuples via the workflow configuration.
The CodeQL static languages team will work on incorporating the support threat models into the existing framework (and some queries).

Even though the code is dead as it is now, it would be good to have it merged to allow CodeQL experiences and the CodeQL static team to work in parallel.
For now we just add some basic testing of the helper predicates.

@github-actions github-actions Bot added the Java label Jun 20, 2023
@michaelnebel michaelnebel marked this pull request as ready for review July 5, 2023 07:31
@michaelnebel michaelnebel requested a review from a team as a code owner July 5, 2023 07:31
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Jul 5, 2023
Copy link
Copy Markdown
Contributor

@jcogs33 jcogs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment and a couple questions, otherwise looks reasonable to me (assuming that the Integration Tests failure is not related to any changes on this PR).

Comment thread java/ql/lib/ext/threatmodels/threat-model-grouping.model.yml Outdated
Comment thread java/ql/lib/ext/threatmodels/threat-model-grouping.model.yml Outdated
Comment thread java/ql/test/library-tests/dataflow/threat-models/threat-models2.ext.yml Outdated
Copy link
Copy Markdown
Contributor

@jcogs33 jcogs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@michaelnebel
Copy link
Copy Markdown
Contributor Author

DCA looks good.

@michaelnebel michaelnebel merged commit e62ec88 into github:main Aug 7, 2023
@michaelnebel michaelnebel deleted the java/threatmodels branch August 7, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants