Skip to content

Upgrade Node.js and actions in publish.yml#115

Merged
manuelpuyol merged 1 commit intomainfrom
manuelpuyol-patch-2
Apr 3, 2026
Merged

Upgrade Node.js and actions in publish.yml#115
manuelpuyol merged 1 commit intomainfrom
manuelpuyol-patch-2

Conversation

@manuelpuyol
Copy link
Copy Markdown
Contributor

Updated Node.js version and action versions in the publish workflow.

Updated Node.js version and action versions in the publish workflow.
@manuelpuyol manuelpuyol requested a review from a team as a code owner April 3, 2026 20:50
Copilot AI review requested due to automatic review settings April 3, 2026 20:50
@manuelpuyol manuelpuyol merged commit 37e5895 into main Apr 3, 2026
7 checks passed
@manuelpuyol manuelpuyol deleted the manuelpuyol-patch-2 branch April 3, 2026 20:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the npm publish GitHub Actions workflow to use newer Node.js and newer major versions of the checkout/setup-node actions.

Changes:

  • Bumps actions/checkout and actions/setup-node major versions in the publish workflow.
  • Changes the configured Node.js version used for publishing.
  • Adjusts setup-node configuration (registry URL format; removes npm caching).
Show a summary per file
File Description
.github/workflows/publish.yml Updates action versions and Node.js configuration for the release publish job

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

registry-url: https://registry.npmjs.org/
cache: npm
node-version: '24'
registry-url: 'https://registry.npmjs.org'
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache: npm was removed from setup-node. This will typically slow down npm ci runs and increase workflow time/cost; if there’s no specific reason to drop caching, re-enable cache: npm (and match the caching approach used in .github/workflows/nodejs.yml).

Suggested change
registry-url: 'https://registry.npmjs.org'
registry-url: 'https://registry.npmjs.org'
cache: npm

Copilot uses AI. Check for mistakes.
registry-url: https://registry.npmjs.org/
cache: npm
node-version: '24'
registry-url: 'https://registry.npmjs.org'
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry-url changed from https://registry.npmjs.org/ to https://registry.npmjs.org and is now quoted, which diverges from the existing workflow (nodejs.yml). If this isn’t intentional, keep the exact same registry URL format across workflows to avoid subtle auth/caching differences.

Suggested change
registry-url: 'https://registry.npmjs.org'
registry-url: https://registry.npmjs.org/

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants