Upgrade Node.js and actions in publish.yml#115
Conversation
Updated Node.js version and action versions in the publish workflow.
There was a problem hiding this comment.
Pull request overview
Updates the npm publish GitHub Actions workflow to use newer Node.js and newer major versions of the checkout/setup-node actions.
Changes:
- Bumps
actions/checkoutandactions/setup-nodemajor versions in the publish workflow. - Changes the configured Node.js version used for publishing.
- Adjusts
setup-nodeconfiguration (registry URL format; removes npm caching).
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Updates action versions and Node.js configuration for the release publish job |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
| registry-url: https://registry.npmjs.org/ | ||
| cache: npm | ||
| node-version: '24' | ||
| registry-url: 'https://registry.npmjs.org' |
There was a problem hiding this comment.
cache: npm was removed from setup-node. This will typically slow down npm ci runs and increase workflow time/cost; if there’s no specific reason to drop caching, re-enable cache: npm (and match the caching approach used in .github/workflows/nodejs.yml).
| registry-url: 'https://registry.npmjs.org' | |
| registry-url: 'https://registry.npmjs.org' | |
| cache: npm |
| registry-url: https://registry.npmjs.org/ | ||
| cache: npm | ||
| node-version: '24' | ||
| registry-url: 'https://registry.npmjs.org' |
There was a problem hiding this comment.
registry-url changed from https://registry.npmjs.org/ to https://registry.npmjs.org and is now quoted, which diverges from the existing workflow (nodejs.yml). If this isn’t intentional, keep the exact same registry URL format across workflows to avoid subtle auth/caching differences.
| registry-url: 'https://registry.npmjs.org' | |
| registry-url: https://registry.npmjs.org/ |
Updated Node.js version and action versions in the publish workflow.