fix(core): Restrict getDataFromUri native bridge methods by antonis · Pull Request #6045 · getsentry/sentry-react-native

antonis · 2026-04-24T13:31:06Z

Type of change

Bugfix (non-breaking change which fixes an issue)

Description

Tightens the URI validation performed by the getDataFromUri native bridge method on both iOS and Android so it only accepts URIs that map to the attachment/screenshot flows the SDK actually uses.

iOS (RNSentry.mm): on top of the existing isFileURL check, the resolved path must sit inside NSTemporaryDirectory(), caches, or documents. Paths containing .. components are rejected before symlink resolution.

Android (RNSentryModuleImpl.java):

content:// — allow only media, the standard SAF document authorities, and the app's own FileProvider.
file:// — only paths under getFilesDir(), getCacheDir(), getExternalFilesDir(null), or getExternalCacheDir() (canonical-path prefix check resolves .. and symlinks).
Other schemes are rejected.

The only in-SDK caller is FeedbackForm.tsx (image picker / screenshot attach), whose URIs fall within the allowed sets on both platforms.

Motivation and Context

Internal security review.

How did you test it?

Added RNSentryUriValidationTest with 17 cases covering accepted and rejected URIs, traversal, prefix collision, unknown schemes, and foreign authorities — all pass via ./gradlew :sentry_react-native:testDebugUnitTest.
Registered a JUnit + Mockito test setup in the Android library module (previously no unit-test target).
yarn build, yarn test, yarn lint, yarn circularDepCheck all clean.

Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

Next steps

iOS: require file URLs to resolve inside NSTemporaryDirectory, caches, or documents. Android: allow content URIs only with known media / SAF document authorities or the app's own FileProvider; file URIs must resolve inside the app's internal/external files or caches dirs. Adds Android unit tests for the validator. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit b51165d. Configure here.}

github-actions · 2026-04-24T13:44:51Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	457.66 ms	448.28 ms	-9.38 ms
Size	43.75 MiB	48.15 MiB	4.40 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4953e94`+dirty	442.02 ms	456.52 ms	14.50 ms
`2c735cc`+dirty	414.09 ms	438.47 ms	24.38 ms
`df5d108`+dirty	527.06 ms	603.58 ms	76.52 ms
`3ce5254`+dirty	410.57 ms	448.48 ms	37.91 ms
`3d377b5`+dirty	406.18 ms	453.52 ms	47.34 ms
`0d9949d`+dirty	403.57 ms	437.00 ms	33.43 ms
`4b87b12`+dirty	421.82 ms	413.60 ms	-8.22 ms
`7ac3378`+dirty	404.78 ms	439.84 ms	35.06 ms
`890d145`+dirty	504.54 ms	491.55 ms	-12.99 ms
`3817909`+dirty	406.67 ms	416.58 ms	9.91 ms

App size

Revision	Plain	With Sentry	Diff
`4953e94`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`2c735cc`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`df5d108`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`3ce5254`+dirty	43.75 MiB	48.12 MiB	4.37 MiB
`3d377b5`+dirty	43.75 MiB	48.14 MiB	4.39 MiB
`0d9949d`+dirty	43.75 MiB	48.13 MiB	4.37 MiB
`4b87b12`+dirty	43.75 MiB	48.14 MiB	4.39 MiB
`7ac3378`+dirty	43.75 MiB	48.13 MiB	4.37 MiB
`890d145`+dirty	43.75 MiB	48.14 MiB	4.39 MiB
`3817909`+dirty	43.75 MiB	48.08 MiB	4.33 MiB

sentry · 2026-04-24T13:47:59Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
Sentry RN	io.sentry.reactnative.sample	8.9.2 (85)	Release

⚙️ sentry-react-native Build Distribution Settings

github-actions · 2026-04-24T13:53:14Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.47 ms	1231.13 ms	6.66 ms
Size	3.38 MiB	4.78 MiB	1.39 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7ac3378`+dirty	1213.37 ms	1218.15 ms	4.78 ms
`4b87b12`+dirty	1212.90 ms	1222.09 ms	9.19 ms
`890d145`+dirty	1223.59 ms	1231.37 ms	7.78 ms
`0d9949d`+dirty	1211.38 ms	1219.67 ms	8.29 ms
`04207c4`+dirty	1191.27 ms	1189.78 ms	-1.48 ms
`3ce5254`+dirty	1219.93 ms	1221.90 ms	1.96 ms
`4953e94`+dirty	1212.06 ms	1214.83 ms	2.77 ms
`2c735cc`+dirty	1229.67 ms	1221.50 ms	-8.17 ms
`a50b33d`+dirty	1197.74 ms	1197.17 ms	-0.57 ms
`df5d108`+dirty	1225.90 ms	1220.14 ms	-5.76 ms

App size

Revision	Plain	With Sentry	Diff
`7ac3378`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`4b87b12`+dirty	3.38 MiB	4.77 MiB	1.39 MiB
`890d145`+dirty	3.38 MiB	4.77 MiB	1.38 MiB
`0d9949d`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`04207c4`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`3ce5254`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`4953e94`+dirty	3.38 MiB	4.73 MiB	1.35 MiB
`2c735cc`+dirty	3.38 MiB	4.74 MiB	1.35 MiB
`a50b33d`+dirty	3.38 MiB	4.73 MiB	1.35 MiB
`df5d108`+dirty	3.38 MiB	4.73 MiB	1.35 MiB

github-actions · 2026-04-24T14:00:55Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1208.15 ms	1212.16 ms	4.02 ms
Size	3.38 MiB	4.78 MiB	1.39 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7ac3378`+dirty	1202.35 ms	1198.31 ms	-4.04 ms
`4b87b12`+dirty	1199.49 ms	1199.78 ms	0.29 ms
`890d145`+dirty	1212.98 ms	1220.10 ms	7.12 ms
`0d9949d`+dirty	1203.94 ms	1202.27 ms	-1.67 ms
`04207c4`+dirty	1228.55 ms	1226.04 ms	-2.51 ms
`3ce5254`+dirty	1217.70 ms	1224.69 ms	6.99 ms
`4953e94`+dirty	1217.41 ms	1223.53 ms	6.12 ms
`2c735cc`+dirty	1223.33 ms	1224.38 ms	1.04 ms
`a50b33d`+dirty	1207.11 ms	1212.10 ms	5.00 ms
`df5d108`+dirty	1207.34 ms	1210.50 ms	3.16 ms

App size

Revision	Plain	With Sentry	Diff
`7ac3378`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`4b87b12`+dirty	3.38 MiB	4.77 MiB	1.39 MiB
`890d145`+dirty	3.38 MiB	4.77 MiB	1.38 MiB
`0d9949d`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`04207c4`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`3ce5254`+dirty	3.38 MiB	4.76 MiB	1.38 MiB
`4953e94`+dirty	3.38 MiB	4.73 MiB	1.35 MiB
`2c735cc`+dirty	3.38 MiB	4.74 MiB	1.35 MiB
`a50b33d`+dirty	3.38 MiB	4.73 MiB	1.35 MiB
`df5d108`+dirty	3.38 MiB	4.73 MiB	1.35 MiB

github-actions · 2026-04-24T14:04:52Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	365.11 ms	404.70 ms	39.60 ms
Size	43.94 MiB	49.01 MiB	5.07 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4953e94`+dirty	398.80 ms	431.81 ms	33.01 ms
`2c735cc`+dirty	435.20 ms	459.48 ms	24.28 ms
`df5d108`+dirty	434.82 ms	447.39 ms	12.57 ms
`3ce5254`+dirty	373.90 ms	427.84 ms	53.94 ms
`3d377b5`+dirty	425.38 ms	440.67 ms	15.30 ms
`0d9949d`+dirty	414.88 ms	428.68 ms	13.81 ms
`4b87b12`+dirty	356.23 ms	399.86 ms	43.63 ms
`7ac3378`+dirty	410.67 ms	442.60 ms	31.92 ms
`890d145`+dirty	486.42 ms	514.85 ms	28.43 ms
`3817909`+dirty	357.52 ms	391.52 ms	34.00 ms

App size

Revision	Plain	With Sentry	Diff
`4953e94`+dirty	43.94 MiB	48.94 MiB	5.00 MiB
`2c735cc`+dirty	43.94 MiB	48.94 MiB	5.00 MiB
`df5d108`+dirty	43.94 MiB	48.94 MiB	5.00 MiB
`3ce5254`+dirty	43.94 MiB	48.98 MiB	5.04 MiB
`3d377b5`+dirty	43.94 MiB	49.00 MiB	5.06 MiB
`0d9949d`+dirty	43.94 MiB	48.99 MiB	5.05 MiB
`4b87b12`+dirty	43.94 MiB	49.00 MiB	5.06 MiB
`7ac3378`+dirty	43.94 MiB	48.99 MiB	5.05 MiB
`890d145`+dirty	43.94 MiB	49.00 MiB	5.06 MiB
`3817909`+dirty	43.94 MiB	48.94 MiB	5.00 MiB

Fixes CI lint:android failure — two line-wrapping tweaks flagged by google-java-format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…muri-restriction

Collapse the trailing if/return-false in isAllowedUri into a single boolean expression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Verified locally via clang-format --Werror. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

lucas-zimerman

LGTM!

lucas-zimerman · 2026-04-28T12:29:57Z

+- Restrict `getDataFromUri` on iOS to the app's temporary, caches, and documents directories ([#6045](https://github.com/getsentry/sentry-react-native/pull/6045))
+- Restrict `getDataFromUri` on Android to known media and document content providers and app-internal file locations ([#6045](https://github.com/getsentry/sentry-react-native/pull/6045))


nit: can't we merge both on a single topic?

Good point 👍 Updated with 934ee43

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…muri-restriction

…list Authority-only matching cannot verify that a SAF URI was granted in the current attach flow versus a previously persisted grant. The in-SDK image picker returns content://media/... on modern Android, so dropping SAF support has no impact on the FeedbackForm flow. Test inverted from allowsSafDocumentsAuthorities to rejectsSafDocumentsAuthorities. Addresses Warden review feedback on #6045. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

antonis added the ready-to-merge Triggers the full CI test suite label Apr 24, 2026

docs(changelog): Link getDataFromUri entries to PR #6045

b51165d

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

cursor Bot reviewed Apr 24, 2026

View reviewed changes

style(android): Apply google-java-format to test file

3c6721e

Fixes CI lint:android failure — two line-wrapping tweaks flagged by google-java-format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sentry-warden Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread packages/core/ios/RNSentry.mm

antonis and others added 3 commits April 28, 2026 10:56

Merge remote-tracking branch 'origin/main' into fix/native-getdatafro…

b207edb

…muri-restriction

style(android): Satisfy PMD SimplifyBooleanReturns

8604b04

Collapse the trailing if/return-false in isAllowedUri into a single boolean expression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

style(ios): Apply clang-format to RNSentry.mm

c84887b

Verified locally via clang-format --Werror. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

antonis marked this pull request as ready for review April 28, 2026 09:55

antonis requested review from alwx and lucas-zimerman as code owners April 28, 2026 09:55

lucas-zimerman approved these changes Apr 28, 2026

View reviewed changes

lucas-zimerman reviewed Apr 28, 2026

View reviewed changes

antonis removed the ready-to-merge Triggers the full CI test suite label Apr 28, 2026

docs(changelog): Merge getDataFromUri entries into one

934ee43

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

antonis mentioned this pull request Apr 28, 2026

Add iOS unit tests for RNSentryIsPathUnderAllowedRoots #6062

Closed

Merge branch 'main' into fix/native-getdatafromuri-restriction

5764f31

sentry-warden Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java Outdated

antonis and others added 2 commits April 28, 2026 15:32

Merge remote-tracking branch 'origin/main' into fix/native-getdatafro…

ca3fd19

…muri-restriction

antonis added the ready-to-merge Triggers the full CI test suite label Apr 28, 2026

antonis merged commit ca37dc6 into main Apr 28, 2026
127 of 137 checks passed

antonis deleted the fix/native-getdatafromuri-restriction branch April 28, 2026 15:01

antonis mentioned this pull request Apr 29, 2026

test(ios): Add unit tests for RNSentryIsPathUnderAllowedRoots #6068

Merged

4 tasks

sentry-release-bot Bot mentioned this pull request Apr 30, 2026

publish: getsentry/sentry-react-native@8.10.0 getsentry/publish#8003

Closed

3 tasks

		- Restrict `getDataFromUri` on iOS to the app's temporary, caches, and documents directories ([#6045](https://github.com/getsentry/sentry-react-native/pull/6045))
		- Restrict `getDataFromUri` on Android to known media and document content providers and app-internal file locations ([#6045](https://github.com/getsentry/sentry-react-native/pull/6045))

Uh oh!

Conversation

antonis commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description

Motivation and Context

How did you test it?

Checklist

Next steps

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

sentry Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

antonis Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

sentry Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading