Skip to content

test: Fix CI caching on Windows#934

Merged
timfish merged 1 commit into
mainfrom
timfish/test/fix-caching-on-windows
May 22, 2026
Merged

test: Fix CI caching on Windows#934
timfish merged 1 commit into
mainfrom
timfish/test/fix-caching-on-windows

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented May 22, 2026

There were intermittent integration test failures in CI on Windows. This was because the */fixtures/node_modules/* directories were getting cached and pnpm on Windows uses copies rather than links.

We don't want any of the fixtures dependencies to be cached anyway!

@timfish timfish marked this pull request as ready for review May 22, 2026 10:56
@timfish timfish requested a review from antonis May 22, 2026 10:56
Copy link
Copy Markdown
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the CI is 🟢 🚀

@timfish timfish merged commit 56e04ce into main May 22, 2026
26 checks passed
@timfish timfish deleted the timfish/test/fix-caching-on-windows branch May 22, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants