fix: Prevent script injection in rust-toolchain-update workflow#3284
Open
fix-it-felix-sentry[bot] wants to merge 1 commit intomasterfrom
Open
fix: Prevent script injection in rust-toolchain-update workflow#3284fix-it-felix-sentry[bot] wants to merge 1 commit intomasterfrom
fix-it-felix-sentry[bot] wants to merge 1 commit intomasterfrom
Conversation
Move GitHub context data from inline interpolation to environment variables to prevent potential script injection attacks. This addresses a high-severity security finding where untrusted data from github.ref_name and workflow outputs could be injected into the github-script action. All GitHub context and workflow output data is now passed through the env: block and accessed via process.env in the script, following GitHub's security best practices. Fixes: https://linear.app/getsentry/issue/VULN-1587 Fixes: https://linear.app/getsentry/issue/ENG-7552 Co-Authored-By: fix-it-felix-sentry[bot] <260785270+fix-it-felix-sentry[bot]@users.noreply.github.com>
fix-it-felix-sentry
Bot
requested review from
a team and
szokeasaurusrex
as code owners
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Prevent script injection in rust-toolchain-update workflow ([#3284](https://github.com/getsentry/sentry-cli/pull/3284))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity security vulnerability where untrusted GitHub context data could be injected into the
github-scriptaction in the rust-toolchain-update workflow.Changes
github.ref_name) and workflow outputs from inline string interpolation to environment variablesprocess.envinstead of direct interpolationSecurity Impact
The previous implementation used
${{ github.ref_name }}directly in the script block, which could allow an attacker to inject arbitrary code if they could control the ref name. The fix follows GitHub's security best practices by using intermediate environment variables.Testing
The workflow logic remains functionally identical - it simply accesses the same data through environment variables instead of direct interpolation. The workflow will be tested on the next scheduled run or manual trigger.
References