fix: Prevent potential shell injection in GitHub Actions workflow#3283
Open
fix-it-felix-sentry[bot] wants to merge 1 commit intomasterfrom
Open
fix: Prevent potential shell injection in GitHub Actions workflow#3283fix-it-felix-sentry[bot] wants to merge 1 commit intomasterfrom
fix-it-felix-sentry[bot] wants to merge 1 commit intomasterfrom
Conversation
Use environment variables to store github context data instead of directly interpolating them in the run script to prevent potential shell injection attacks. Fixes: https://linear.app/getsentry/issue/VULN-1586 Fixes: https://linear.app/getsentry/issue/ENG-7551 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
fix-it-felix-sentry
Bot
requested review from
a team and
szokeasaurusrex
as code owners
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Prevent potential shell injection in GitHub Actions workflow ([#3283](https://github.com/getsentry/sentry-cli/pull/3283))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a security finding by preventing potential shell injection in the GitHub Actions workflow.
Changes
.github/workflows/release-ghcr-version-tag.ymlto use environment variables instead of directly interpolatinggithub.ref_nameandgithub.shain therun:scriptenv:block to store GitHub context data in intermediate variables"$REF_NAME"and"$SHA")Security Context
While this workflow only runs on release events (controlled by repository maintainers), following security best practices requires treating all GitHub context data as potentially untrusted input. Using intermediate environment variables prevents potential shell injection attacks.
Related Issues
Testing
The workflow syntax has been updated following GitHub's security hardening guidelines. The functionality remains unchanged - the workflow will continue to tag Docker images on release events.