[Repo Assist] eng: add net8.0 target to FSharp.Data.Html.Core, .Http, and .WorldBank.Core#1765
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
…k.Core
Three source packages were inconsistently targeting only netstandard2.0
while the rest of the package set targets netstandard2.0;net8.0:
Before (single-target):
FSharp.Data.Html.Core → netstandard2.0
FSharp.Data.Http → netstandard2.0
FSharp.Data.WorldBank.Core → netstandard2.0
After (multi-target, consistent with other packages):
FSharp.Data.Html.Core → netstandard2.0;net8.0
FSharp.Data.Http → netstandard2.0;net8.0
FSharp.Data.WorldBank.Core → netstandard2.0;net8.0
Benefits:
- Fixes pre-existing NETSDK1212 warnings: the existing
<IsTrimmable>true</IsTrimmable> flag requires a net6.0+
TFM to be valid; adding net8.0 makes trim analysis work
correctly for these packages.
- Provides a dedicated net8.0 DLL for consumers on .NET 8+,
enabling future net8.0-specific optimisations.
- Makes the package set consistent.
All affected tests pass (245 passed, 0 failed).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Three source packages were inconsistently targeting only
netstandard2.0while the rest of the package set targetsnetstandard2.0;net8.0.Root Cause
The following packages had
<TargetFramework>netstandard2.0</TargetFramework>(singular) instead of<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>(plural):FSharp.Data.Html.Corenetstandard2.0netstandard2.0;net8.0FSharp.Data.Httpnetstandard2.0netstandard2.0;net8.0FSharp.Data.WorldBank.Corenetstandard2.0netstandard2.0;net8.0All other packages (
FSharp.Data,FSharp.Data.Csv.Core,FSharp.Data.Json.Core,FSharp.Data.Xml.Core,FSharp.Data.Runtime.Utilities,FSharp.Data.DesignTime) already targetnetstandard2.0;net8.0.Why This Matters
Fixes pre-existing NETSDK1212 warnings: The existing
<IsTrimmable>true</IsTrimmable>flag is only valid fornet6.0+targets. Building these packages with onlynetstandard2.0generates:Adding
net8.0makes trim analysis work correctly.Provides a dedicated
net8.0DLL for consumers on .NET 8+, enabling futurenet8.0-specific optimisations (e.g.,System.Net.Httpnative APIs inFSharp.Data.Http).Makes the package set consistent — all published packages now target the same set of frameworks.
Changes
src/FSharp.Data.Html.Core/FSharp.Data.Html.Core.fsproj—TargetFramework→TargetFrameworkssrc/FSharp.Data.Http/FSharp.Data.Http.fsproj—TargetFramework→TargetFrameworkssrc/FSharp.Data.WorldBank.Core/FSharp.Data.WorldBank.Core.fsproj—TargetFramework→TargetFrameworksNo source code changes.
Test Status
dotnet build src/FSharp.Data.Html.Core/— succeeded, 0 warnings (was 1× NETSDK1212)dotnet build src/FSharp.Data.Http/— succeeded, 0 warningsdotnet build src/FSharp.Data.WorldBank.Core/— succeeded (1 pre-existing FS0044 forUri.EscapeUriString, unrelated to this change)dotnet test tests/FSharp.Data.Core.Tests/ --filter "HtmlParser|HtmlOperations|WorldBankRuntime|Http"— 245 passed, 0 failedmainfails with pre-existingNU1902(OpenTelemetry.Api 1.15.0vulnerability, addressed separately in PR [Repo Assist] eng: fix OpenTelemetry.Api GHSA-g94r-2vxg-569j by pinning >= 1.15.1 and updating GitHubActionsTestLogger to 3.0.3 #1762)