fix: download db.json in production#1911
Closed
ojeytonwilliams wants to merge 1 commit intofreeCodeCamp:mainfrom
Closed
fix: download db.json in production#1911ojeytonwilliams wants to merge 1 commit intofreeCodeCamp:mainfrom
ojeytonwilliams wants to merge 1 commit intofreeCodeCamp:mainfrom
Conversation
The offline page uses it to get the size of each doc
Contributor
|
I @ojeytonwilliams, thank you for looking into this issue. It's a regression of #1293. It's an issue not reproducible using the local development server |
Merged
Contributor
Author
|
You're welcome - I thought it was worth me having a go, even though I knew you'd be on top of it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1910
@simon04 there's probably a better approach where we point the app at documents.devdocs.io (since https://documents.devdocs.io/bash/db.json and the like do exist), but this was the best I could up with for now!