Wire up createViewTransitionInstance in Fabric#36196
Open
zeyap wants to merge 2 commits intofacebook:mainfrom
Open
Wire up createViewTransitionInstance in Fabric#36196zeyap wants to merge 2 commits intofacebook:mainfrom
zeyap wants to merge 2 commits intofacebook:mainfrom
Conversation
Extract the tag allocation logic into a shared `allocateTag()` function in ReactFiberConfigFabric and use it in both `createInstance`/`createTextInstance` and `createViewTransitionInstance` in the ViewTransition config. Also wire up the native `fabricCreateViewTransitionInstance` call.
zeyap
changed the title
|
Comparing: 80b1cab...71e5fc2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
…wTransitionInstance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fabricCreateViewTransitionInstancecall increateViewTransitionInstancewhich will create a ShadowNode for old pseudo elementallocateTag()function exported fromReactFiberConfigFabricallocateTaginReactFiberConfigFabricWithViewTransitionallocateTag()increateInstanceandcreateTextInstanceinstead of inline tag incrementingTest plan