Skip to content

[dependabot] Ignore all fixture directories#31074

Merged
poteto merged 4 commits intogh/poteto/16/basefrom
gh/poteto/16/head
Sep 26, 2024
Merged

[dependabot] Ignore all fixture directories#31074
poteto merged 4 commits intogh/poteto/16/basefrom
gh/poteto/16/head

Conversation

@poteto
Copy link
Copy Markdown
Contributor

@poteto poteto commented Sep 26, 2024

Stack from ghstack (oldest at bottom):

Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

[ghstack-poisoned]
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:25pm

poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: a47db58
Pull Request resolved: #31074
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 26, 2024
@react-sizebot
Copy link
Copy Markdown

react-sizebot commented Sep 26, 2024

Comparing: b7f74f39d8979307354f0d5c8a5daa8456ea4f2f...f27aa92dee4ff1aadf430cd25cf4eee91500226a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.20 kB 507.20 kB = 90.80 kB 90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.13 kB 512.13 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.73 kB = 106.84 kB 106.83 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.95 kB = 102.92 kB 102.92 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 65f9009

Copy link
Copy Markdown
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify this a bunch using directories, per https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#directories

it should support wildcards for the plural version.

So something like

  - package-ecosystem: "npm"
    directories:
      - "/fixtures/*"
    schedule:
      interval: "monthly"
    ignore:
      - dependency-name: "*"

@poteto
Copy link
Copy Markdown
Contributor Author

poteto commented Sep 26, 2024

@kassens oh sweet, nice find!

[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: bae3a9e
Pull Request resolved: #31074
@poteto poteto requested a review from kassens September 26, 2024 14:19
Comment thread .github/dependabot.yml Outdated
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: 8864a90
Pull Request resolved: #31074
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: 64b76bd
Pull Request resolved: #31074
@poteto poteto merged commit 65f9009 into gh/poteto/16/base Sep 26, 2024
poteto added a commit that referenced this pull request Sep 26, 2024
Seems like we can specify a wildcard dependency name to ignore all
dependencies from being updated. As I understand it dependabot will
still run monthly but no PRs will be generated.

ghstack-source-id: 64b76bd
Pull Request resolved: #31074
@poteto poteto deleted the gh/poteto/16/head branch September 26, 2024 14:34
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-778e1ed2-20240926` to `19.0.0-rc-3edc000d-20240926`**

[diff
facebook/react@778e1ed2...3edc000d](facebook/react@778e1ed...3edc000)

<details>
<summary>React upstream changes</summary>

- facebook/react#31078
- facebook/react#31083
- facebook/react#31079
- facebook/react#31080
- facebook/react#31076
- facebook/react#31021
- facebook/react#31069
- facebook/react#31074
- facebook/react#31073
- facebook/react#31047
- facebook/react#31046
- facebook/react#31045
- facebook/react#31072
- facebook/react#30980
- facebook/react#30463
- facebook/react#30694
- facebook/react#31039
- facebook/react#31048
- facebook/react#31068

</details>

---------

Co-authored-by: Josh Story <story@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants