Console Logging for StrictMode Double Rendering#22030
Merged
lunaruan merged 6 commits intofacebook:mainfrom Aug 25, 2021
Merged
Console Logging for StrictMode Double Rendering#22030lunaruan merged 6 commits intofacebook:mainfrom
lunaruan merged 6 commits intofacebook:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21889.
React currently suppress console logs in StrictMode during double rendering. However, this causes a lot of confusion. This PR moves the console suppression logic from React into React Devtools. Now by default, we no longer suppress console logs. Instead, we gray out the logs in console during double render. We also add a setting in React Devtools to allow developers to hide console logs during double render if they choose.
New default console behavior
Chrome (Dark/Light):


Firefox (Dark/Light):

Safari (Dark/Light):


Edge (Dark/Light):


Node:

New Devtools setting:
