[TestUtils.act] fix return result checking #14758
Merged
threepointone merged 36 commits intofacebook:masterfrom Feb 5, 2019
Merged
[TestUtils.act] fix return result checking #14758threepointone merged 36 commits intofacebook:masterfrom
threepointone merged 36 commits intofacebook:masterfrom
Conversation
added 30 commits
February 1, 2019 14:54
can't return values from .act don't try to await .act calls pass tests
added 4 commits
February 5, 2019 15:50
Contributor
Author
|
doing a merge in with master, gimme a minute |
bvaughn
approved these changes
Feb 5, 2019
| if (result !== undefined) { | ||
| let addendum; | ||
| if (typeof result.then === 'function') { | ||
| if (result && typeof result.then === 'function') { |
Contributor
There was a problem hiding this comment.
super tiny nit result !== null && ...
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* fix .act return value testing when result === null * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a bug from #14744 where returning null from
.actwould throw when null. Sorry! Added a test to be sure.