Enable hooks by default for FB React Native renderer#14435
Merged
bvaughn merged 2 commits intofacebook:masterfrom Dec 13, 2018
Merged
Enable hooks by default for FB React Native renderer#14435bvaughn merged 2 commits intofacebook:masterfrom
bvaughn merged 2 commits intofacebook:masterfrom
Conversation
sebmarkbage
reviewed
Dec 13, 2018
| @@ -23,6 +22,7 @@ export const { | |||
| } = require('ReactFeatureFlags'); | |||
Contributor
There was a problem hiding this comment.
The rest of these, are they still relevant to be dynamic or can we just turn them on or off?
Contributor
There was a problem hiding this comment.
Only debugRenderPhaseSideEffects is currently dynamically configured internally.
We always set debugRenderPhaseSideEffectsForStrictMode to true.
Contributor
Author
There was a problem hiding this comment.
Looks like debugRenderPhaseSideEffects is a dynamic value, debugRenderPhaseSideEffectsForStrictMode is being set to true in InitializeReactFeatureFlags, and nothing is changing the default value of warnAboutDeprecatedLifecycles.
sebmarkbage
approved these changes
Dec 13, 2018
Details of bundled changes.Comparing: a22880e...f7eaa2d react-native-renderer
Generated by 🚫 dangerJS |
Contributor
Author
|
I've pushed another commit to this branch that makes all but one of the flags ( Here are the new flag values:
|
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Enable hooks by default for FB React Native renderer * Updated RN+FB feature flags to make some of the dynamic ones static
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Enable hooks by default for FB React Native renderer * Updated RN+FB feature flags to make some of the dynamic ones static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.