Update shell tab completion for exercism cli#759
Merged
kytrinyx merged 2 commits intoexercism:masterfrom Nov 5, 2018
Merged
Conversation
6183f9e to
e98310f
Compare
Contributor
Author
|
@kytrinyx I confirmed completion is working as expected for zsh and bash on my end. But I would like to confirm that the changes work as expected on another user's machine before merging. Let me know if you have time to take a look. |
Member
|
This works on my machine! |
|
@kytrinyx why do we need additional configuration to get tab completion? Can't it come out of the box? |
Member
|
@Atulkmr I'm not sure I understand your question. The binary that we deliver cannot control your machine's path. The extra configuration is what tells your machine about the options for the binary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does?
The Bash and Zsh tab completion files being shipped with the latest release reference subcommands that no longer exist. This changes updates the shell completion files with references to all of the implemented commands in Exercism v2.
** Note ** auto Bash completion generation in Cobra was looked into but it appears that Cobra requires a bit of configuration for each command we would want to generate bash completions for so I am going with manual update at this time.
How to test?
exercism <tab>)resolves #666