Handle exercise directories with numeric suffixes#722
Merged
Conversation
kytrinyx
force-pushed
the
numeric-suffix
branch
2 times, most recently
from
5569709 to
be218b6
Compare
Contributor
|
@kytrinyx pay no attention to my previous comment; in fact I deleted it because it was way off. I see the error of my ways now. |
nywilken
approved these changes
Aug 28, 2018
Contributor
nywilken
left a comment
nywilken
left a comment
There was a problem hiding this comment.
It took me a minute to get what was going on here. But I got it. This is good to go. I recommend a rebase to keep the history in order. But great stuff.
added 2 commits
August 28, 2018 16:14
An early design decision was to allow people to work on multiple solutions to the same exercise at the same time. We later decided not to do this, but the CLI still had logic that supported it. This caused us to (incorrectly) create exercise directories that were named with a numeric suffix, which would then get submitted to the backend server, which doesn't care about filepaths. Because the exercise with the numeric suffix doesn't match the expected path, we did not correctly trim off any leading directories on submit, which further caused the download command to put the solution in a weirdly and deeply nested directory, making the solution hard to find and review.
kytrinyx
force-pushed
the
numeric-suffix
branch
from
be218b6 to
3ed08d2
Compare
Member
Author
|
Thanks @nywilken. I was a but unsure how much context to add to the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An early design decision was to allow people to work on multiple solutions to the same
exercise at the same time. We later decided not to do this, but the CLI still had
logic that supported it.
This caused us to (incorrectly) create exercise directories that were named with a
numeric suffix, which would then get submitted to the backend server, which doesn't
care about filepaths.
Because the exercise with the numeric suffix doesn't match the expected path, we did
not correctly trim off any leading directories on submit, which further caused
the download command to put the solution in a weirdly and deeply nested directory,
making the solution hard to find and review.
Closes exercism/exercism#4275
Closes exercism/exercism#4066