Guard against submitting _spec.* files and READMEs

[daveyarwood]

Closes #272.

I see that we allow users to submit test files if they include a --test flag (#189) -- should we do the same to allow submitting READMEs? If so, I propose we change the --test flag to a --force flag and let it apply to READMEs and any other files we may want to complain about in the future.

[Tonkpils]

Nope, I don't think we ever want to allow submitting the README. This looks great :)

[kytrinyx]

perl doesn't have test or spec in the name, for what it's worth. Languages that have a different pattern for the test files have this defined in the language config, so we could expose it via the API (and perhaps write it to a dotfile somewhere that we can load and check.

[daveyarwood]

I like that idea, seems much safer.
On Jan 21, 2016 2:37 PM, "Katrina Owen" notifications@github.com wrote:

In cmd/cmd.go
#273 (comment):

@@ -17,8 +18,12 @@ func isTest(path string) bool {

file := filepath.Base(path)
name := file[:len(file)-len(ext)]

• if name == "test" {
• if name == "test" || name == "spec" {

perl doesn't have test or spec in the name, for what it's worth. Languages
that have a different pattern for the test files have this defined in the
language config, so we could expose it via the API (and perhaps write it to
a dotfile somewhere that we can load and check.

—
Reply to this email directly or view it on GitHub
https://github.com/exercism/cli/pull/273/files#r50451141.

[kytrinyx]

OK cool, I'll add an issue for it.

[kytrinyx]

https://github.com/exercism/x-api/issues/95