Skip to content

avoid ambiguous or unresolvable exercism paths#208

Merged
Tonkpils merged 2 commits intoexercism:masterfrom
lcowell:master
Aug 3, 2015
Merged

avoid ambiguous or unresolvable exercism paths#208
Tonkpils merged 2 commits intoexercism:masterfrom
lcowell:master

Conversation

@lcowell
Copy link
Copy Markdown
Contributor

@lcowell lcowell commented Aug 3, 2015

Prepend any relative path with the current working directory so the path can be absolute and will be resolvable no matter what directory you're in.

Fixes #205

Update is not guaranteed to work, we should handle any returned errors.
cmd/configure.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we scope this in the if statement like so.

if err := c.Update(...); err != nil {

@lcowell
Copy link
Copy Markdown
Contributor Author

lcowell commented Aug 3, 2015

Thanks @Tonkpils - I've implemented your suggestions.

@Tonkpils
Copy link
Copy Markdown
Contributor

Tonkpils commented Aug 3, 2015

This is a great fix! Thanks!

Tonkpils added a commit that referenced this pull request Aug 3, 2015
avoid ambiguous or unresolvable exercism paths
@Tonkpils Tonkpils merged commit 33de50b into exercism:master Aug 3, 2015
@kytrinyx
Copy link
Copy Markdown
Member

kytrinyx commented Aug 8, 2015

+1000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants