Make file paths in config_test OS agnostic#128
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Oct 2, 2014
Merged
Conversation
Member
|
Oh, nice find! I've tried to use FromSlash() or Clean() etc where appropriate, but it's hard to catch them when the tests just pass on my system. Thank you ❤️ |
kytrinyx
added a commit
that referenced
this pull request
Oct 2, 2014
Make file paths in config_test OS agnostic
lcowell
pushed a commit
to lcowell/cli
that referenced
this pull request
Jan 25, 2015
Make file paths in config_test OS agnostic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to do an initial build on Windows 8, the modified tests were failing because they were expecting unix '/'s, but were getting windows style double-backslash. The filepath.FromSlash function was trivially easy to use, and made the tests pass on my system.
Note: I otherwise have absolutely NO clue what these tests are actually doing...