Modernize to build with newer Python 3 versions; improve tests#32
Merged
Conversation
MartyMacGyver
force-pushed
the
mff-modernize
branch
from
29d17e5 to
41c6cf9
Compare
MartyMacGyver
changed the title
Contributor
Author
|
This should be a more durable fix for #29 but needs more testing |
Using the int cast in the 128-bit logic causes Cython to emit __Pyx_PyLong_From_uint64_t((__pyx_v_result.first << 64ULL)) instead of the broken PyNumber_Lshift(__pyx_t_9, __pyx_mstate_global->__pyx_int_64L) when we shift left a "long" int with 64ULL Added a test that actually checks the value returned for the 128-bit hashes.
MartyMacGyver
force-pushed
the
mff-modernize
branch
from
41c6cf9 to
36f07c1
Compare
escherba
added a commit
that referenced
this pull request
Aug 2, 2025
* ci: bump actions/upload-artifact to v4 * ci: bump ubuntu os to 24.04 * add cp312 support (v0.3.4) * ci: bump cibuildwheel to 2.23.3 * Modernize to build with newer Python 3 versions; improve tests (#32) Using the int cast in the 128-bit logic causes Cython to emit __Pyx_PyLong_From_uint64_t((__pyx_v_result.first << 64ULL)) instead of the broken PyNumber_Lshift(__pyx_t_9, __pyx_mstate_global->__pyx_int_64L) when we shift left a "long" int with 64ULL Added a test that actually checks the value returned for the 128-bit hashes. Co-authored-by: Eugene Scherba <escherba@gmail.com> * add cp313 and update workflows --------- Co-authored-by: florianvazelle <ponythugflorian@gmail.com> Co-authored-by: Martin Falatic <martin@falatic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the int cast in the 128-bit logic causes Cython to emit
__Pyx_PyLong_From_uint64_t((__pyx_v_result.first << 64ULL))instead of the broken
PyNumber_Lshift(__pyx_t_9, __pyx_mstate_global->__pyx_int_64L)when we shift left a "long" int with 64ULL
Added a test that actually checks the value returned for the
128-bit hashes.