Fix bytes support in multipart uploads#974
Merged
Merged
Conversation
florimondmanca
force-pushed
the
fix-bytes-file-content
branch
from
19d3a09 to
882994d
Compare
Merged
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
* Add proxy configuration to ConnectionPool * Update tests for new proxy API, and nocover old classes. * Update CHANGELOG * Iterate refactor * Revert "Iterate refactor" This reverts commit e3835579d15cdbee17eaffb444bd427ddf94d41d. --------- Co-authored-by: Tom Christie <tomchristie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filesargument allowsstr/bytesalong with file objects, but we were not handling thebytesbranch yet (incorrectly treating that as file objects).I've provided a test, but also have a follow-up PR coming to tighten up the type checking in the multipart implementation (which was too lose for mypy to catch this).