You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To my mind such attribute checking is rather dubious because if stream must be closed then method to close it is part of its interface and thus all wrappers, mocks or substitutions must to implement it even if they are not required to be closed.
To my mind such attribute checking is rather dubious
I'd tend to agree yup, since the AsyncByteStream and SyncByteStream interface, documented here: https://www.encode.io/httpcore/api/, specify a .aclose() and .close() method respectively. Happy to consider removing this attribute checking as a follow-up!
Happily we'll be moving away from the stream .close() interface anyways.
Once we're treating HTTPTransport.request() as a context manager byte streams will just be either Iterable[byte] or AsyncIterable[byte]. (See #1274, encode/httpcore#145)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asynchronous
httpcorestreams do not haveclose()method, they provideaclose(). Fixes #1315 .