Fix GetMinMergedCell for cells spanning all columns and multiple rows#359
Open
th-joerger wants to merge 1 commit intoempira:masterfrom
Open
Fix GetMinMergedCell for cells spanning all columns and multiple rows#359th-joerger wants to merge 1 commit intoempira:masterfrom
th-joerger wants to merge 1 commit intoempira:masterfrom
Conversation
When a single cell spans all columns (MergeRight = columnCount - 1) and
more than one row (MergeDown >= 1), GetMinMergedCell() throws
InvalidOperationException because the condition
resultRowIndex + cell.MergeDown == row
simplifies to MergeDown == 0, which the origin cell (MergeDown >= 1) does
not satisfy. All other cells in that row are excluded because they are not
in _mergedCells (they are covered by the merge).
Fix: add a fallback loop that finds the cell with the minimum MergeDown
value in _mergedCells for the given row. This matches the behaviour of
GetMinMergedCellOriginal() which handles this case correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358
When a single cell spans all columns (MergeRight = columnCount - 1) and more than one row (MergeDown >= 1), GetMinMergedCell() throws InvalidOperationException because the condition
simplifies to MergeDown == 0, which the origin cell (MergeDown >= 1) does not satisfy. All other cells in that row are excluded because they are not in _mergedCells (they are covered by the merge).
Fix: add a fallback loop that finds the cell with the minimum MergeDown value in _mergedCells for the given row. This matches the behaviour of GetMinMergedCellOriginal() which handles this case correctly.