[BUGFIX release] Fix implicit-modules naming#21244
Merged
kategengler merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
The bug here is: - in a classic build - with use-ember-modules enabled - a v1 addon that does not have a dependency on ember-auto-import - tries to access a module from ember that nobody else was already importing via ember-auto-import This case is supposed to work because of the implicit-modules list defined in lib/index.js. But that list had several mismatches between the actual files in `dist` and the way they're spelled in lib/index.js. ember-auto-import cares about the difference. If we backport this (possibly as far as 6.10, since that's where use-ember-modules is introduced), we need to be aware of making this list match the actual `dist` produced on that ember version. These files changed at the point where the glimmer packages moved into the monorepo.
ef4
changed the title
Contributor
📊 Package size report 0%↑
🤖 This report was automatically generated by pkg-size-action |
NullVoxPopuli
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug here is:
This case is supposed to work because of the implicit-modules list defined in lib/index.js. But that list had several mismatches between the actual files in
distand the way they're spelled in lib/index.js. ember-auto-import cares about the difference.If we backport this (possibly as far as 6.10, since that's where use-ember-modules is introduced), we need to be aware of making this list match the actual
distproduced on that ember version. These files changed at the point where the glimmer packages moved into the monorepo.