Skip to content

Fix subagent chat ID validation regression#453

Merged
ericdallo merged 1 commit into
editor-code-assistant:masterfrom
itkonen:fix/subagent-chat-id-validation
May 8, 2026
Merged

Fix subagent chat ID validation regression#453
ericdallo merged 1 commit into
editor-code-assistant:masterfrom
itkonen:fix/subagent-chat-id-validation

Conversation

@itkonen
Copy link
Copy Markdown
Contributor

@itkonen itkonen commented May 8, 2026

Sub-agent spawning stopped working for me in the latest release, 0.133.1. I tested these changes locally, and sub-agent spawning works again with this fix.

The summary below is AI-generated.

Summary

Fix a regression where spawn_agent was rejected by chat/prompt because server-managed subagent chat IDs use the reserved subagent- prefix.

The validation still rejects client-created subagent-* IDs, but allows an existing chat that has already been seeded as a server-managed subagent.

Test plan

  • clojure -M:test --focus eca.features.chat-test/prompt-rejects-invalid-client-chat-id-test
  • clojure -M:test --focus eca.features.tools.agent-test

Checklist

  • I added a entry in changelog under unreleased section.
  • This is not an AI slop.

🤖 Generated with eca

Allow chat/prompt to accept reserved subagent chat IDs only when
the server has already seeded that chat as a managed subagent.

🤖 Generated with [eca](https://eca.dev)

Co-Authored-By: eca-agent <git@eca.dev>
Copy link
Copy Markdown
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ericdallo ericdallo merged commit abc59a2 into editor-code-assistant:master May 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants