:bomb: `Bug`: Execute Command `dtm develop validate-plugin -a` Failed

[daniel-hutao]

What Happened?

$ dtm develop validate-plugin -a
2022-09-29 20:02:57 ✖ [FATAL]  the name must be not "", you can specify it by --name flag

How to Reproduce?

Execute dtm develop validate-plugin -a

Anything else

This command should validate all plugins.

DevStream Version

latest

[caelaxie]

With the latest commit (ad09525), this command is still not working.

[caelaxie]

I think this is caused by a known bug in viper: spf13/viper#233

[caelaxie]

These are the flags within viper during a debugging session:

It seems like the --all flag of validate-plugin commaned has not been added to viper.

[caelaxie]

A workaround is like this:

And it works!

[IronCore864]

A workaround is like this:

And it works!

Great. Could you contribute a PR? Thanks in advance :)

[caelaxie]

A workaround is like this:
And it works!

Great. Could you contribute a PR? Thanks in advance :)

sure

[daniel-hutao]

With the latest commit (ad09525), this command is still not working.

@algobot76 It seems like another bug: #1141

Let's go back to the original error logs:

$ dtm develop validate-plugin -a
2022-09-29 20:02:57 ✖ [FATAL]  the name must be not "", you can specify it by --name flag

Maybe it's enough if we tweak the code here:

devstream/internal/pkg/develop/plugin/validate.go

Lines 20 to 23 in f56c8b7

	name := viper.GetString("name")
	if name == "" {
	return fmt.Errorf(`the name must be not "", you can specify it by --name flag`)
	}

[caelaxie]

With the latest commit (ad09525), this command is still not working.

@algobot76 It seems like another bug: #1141

Let's go back to the original error logs:

$ dtm develop validate-plugin -a
2022-09-29 20:02:57 ✖ [FATAL]  the name must be not "", you can specify it by --name flag

Maybe it's enough if we tweak the code here:

devstream/internal/pkg/develop/plugin/validate.go

Lines 20 to 23 in f56c8b7

	name := viper.GetString("name")
	if name == "" {
	return fmt.Errorf(`the name must be not "", you can specify it by --name flag`)
	}

devstream/internal/pkg/develop/plugin/validate.go

Lines 12 to 27 in f56c8b7

	func Validate() error {
	validateAll := viper.GetBool("all")
	if validateAll {
	log.Info("Start validating all plugins.\n")
	return ValidatePlugins()
	}
	name := viper.GetString("name")
	if name == "" {
	return fmt.Errorf(`the name must be not "", you can specify it by --name flag`)
	}
	log.Debugf("Got the name: %s.", name)
	return ValidatePlugin(name)
	}

validateAll is always false due to the bug in viper, which I mentioned before. So L20 will be executed when you run dtm develop validate-plugin -a. In this case, name is an empty string, thus the error message the name must be not "", you can specify it by --name flag will show up.

[caelaxie]

The reason my log is different from yours is that I have an environment variable called name in my computer

According to the source code of Viper, it will look for environment variables if the flag is not set