fix(release): install dapr-sdk-bom locally before bumping dapr-spring-bom#1744
Merged
javier-aliaga merged 1 commit intoMay 14, 2026
Merged
Conversation
…-bom The release script bumps the dapr.sdk.version property in all reactor POMs (including dapr-spring-bom) before bumping the standalone BOMs. The later 'mvn versions:set -f dapr-spring/dapr-spring-bom/pom.xml' runs in single-POM mode (no reactor) and tries to resolve the import dapr-sdk-bom at the new version, which is not yet installed. Install sdk-bom into the local repo between the two BOM updates so the import resolves. Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
force-pushed
the
fix/release-install-sdk-bom-locally
branch
from
cb47493 to
90a0b53
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1744 +/- ##
============================================
- Coverage 76.80% 76.76% -0.05%
Complexity 2260 2260
============================================
Files 241 241
Lines 7066 7066
Branches 740 740
============================================
- Hits 5427 5424 -3
- Misses 1276 1279 +3
Partials 363 363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salaboy
approved these changes
May 14, 2026
siri-varma
added a commit
that referenced
this pull request
May 14, 2026
…-bom (#1744) (#1745) The release script bumps the dapr.sdk.version property in all reactor POMs (including dapr-spring-bom) before bumping the standalone BOMs. The later 'mvn versions:set -f dapr-spring/dapr-spring-bom/pom.xml' runs in single-POM mode (no reactor) and tries to resolve the import dapr-sdk-bom at the new version, which is not yet installed. Install sdk-bom into the local repo between the two BOM updates so the import resolves. (cherry picked from commit 2c038f4) Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release script bumps the dapr.sdk.version property in all reactor POMs (including dapr-spring-bom) before bumping the standalone BOMs. The later 'mvn versions:set -f dapr-spring/dapr-spring-bom/pom.xml' runs in single-POM mode (no reactor) and tries to resolve the import dapr-sdk-bom at the new version, which is not yet installed.
Install sdk-bom into the local repo between the two BOM updates so the import resolves.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: