Skip to content

fixed #14675 - provide proper error ID for simplecpp::Output::EXPLICIT_INCLUDE_NOT_FOUND#8462

Merged
firewave merged 1 commit intodanmar:mainfrom
firewave:inc-expl
Apr 23, 2026
Merged

fixed #14675 - provide proper error ID for simplecpp::Output::EXPLICIT_INCLUDE_NOT_FOUND#8462
firewave merged 1 commit intodanmar:mainfrom
firewave:inc-expl

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@sonarqubecloud
Copy link
Copy Markdown

@IOBYTE
Copy link
Copy Markdown
Contributor

IOBYTE commented Apr 20, 2026

with this PR I now get:
C:/Users/Bob/acclint/ac3d.cpp:0:0:error: Can not open include file '' that is explicitly included. [missingIncludeExplicit]

Would it be possible to show which include is causing this error?

@firewave
Copy link
Copy Markdown
Collaborator Author

Would it be possible to show which include is causing this error?

As you can see in the added tests the name should be included. Your error message indicates that an empty filename was specified.

How do you invoke the analysis? My hunch is that you are using a project and we are handling some empty field incorrectly.

On a side note we could (should?) already bail out at the CLI parsing level. But I would like to cover that separately.

@IOBYTE
Copy link
Copy Markdown
Contributor

IOBYTE commented Apr 21, 2026

I'm on windows 10 using the GUI to open a project which opens a vcxproj file.

Here is my code: https://github.com/IOBYTE/acclint

@firewave
Copy link
Copy Markdown
Collaborator Author

I can reproduce it and will file a separate ticket for the issue.

@firewave
Copy link
Copy Markdown
Collaborator Author

The issue was introduced in #8454 and if I understand it correctly that causes every analysis in the GUI to fail. I do not understand how this got through.

@firewave firewave merged commit e6807a4 into danmar:main Apr 23, 2026
72 checks passed
@firewave firewave deleted the inc-expl branch April 23, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants