Skip to content

Fix #14684: FP unreadVariable with auto and brace-init #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludviggunne wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −0
Open

Fix #14684: FP unreadVariable with auto and brace-init #8508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec676f
add test
ludviggunne Apr 28, 2026
01f6f39
fix
ludviggunne Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/symboldatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6935,6 +6935,13 @@ void SymbolDatabase::setValueType(Token* tok, const ValueType& valuetype, const
if (!parent->astOperand1())
return;

if (Token::Match(parent->astOperand1()->previous(), "auto %var% {")) {
Copy link
Copy Markdown
Collaborator

@chrchr-github chrchr-github Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be variations like auto&& or auto const&.
Is the ValueType set correctly for e.g. T t{ 1 }?

Copy link
Copy Markdown
Collaborator Author

@ludviggunne ludviggunne Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the T from a template? I would assume it would be set to whatever it is in the instantiation, but i can double check.

ValueType vt(*valuetypePtr);
vt.reference = Reference::None;
parent->astOperand1()->setValueType(new ValueType(vt));
}


const ValueType *vt1 = parent->astOperand1()->valueType();
const ValueType *vt2 = parent->astOperand2() ? parent->astOperand2()->valueType() : nullptr;

Expand Down
7 changes: 7 additions & 0 deletions test/testunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class TestUnusedVar : public TestFixture {
TEST_CASE(localvar70);
TEST_CASE(localvar71);
TEST_CASE(localvar72);
TEST_CASE(localvar73);
TEST_CASE(localvarloops); // loops
TEST_CASE(localvaralias1);
TEST_CASE(localvaralias2); // ticket #1637
Expand Down Expand Up @@ -4061,6 +4062,12 @@ class TestUnusedVar : public TestFixture {
ASSERT_EQUALS("[test.cpp:4:12]: (style) Unused variable: mp [unusedVariable]\n", errout_str());
}

void localvar73() {
functionVariableUsage("struct S { S(); ~S(); };\n"
"void f() { auto s{ S() }; }\n");
Comment thread
ludviggunne marked this conversation as resolved.
ASSERT_EQUALS("", errout_str());
}

void localvarloops() {
// loops
functionVariableUsage("void fun(int c) {\n"
Expand Down
Loading