Skip to content

Tokenizer: removed Preprocessor dependency#6265

Merged
firewave merged 3 commits intocppcheck-opensource:mainfrom
firewave:directives
Apr 11, 2024
Merged

Tokenizer: removed Preprocessor dependency#6265
firewave merged 3 commits intocppcheck-opensource:mainfrom
firewave:directives

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

This might not be the logical place for the directives but it is the best place in terms of the code.

@firewave
Copy link
Copy Markdown
Collaborator Author

I might move the whole logic into a separate object in the future but I have no idea where to place it yet. It might be clearer after finishing #5323.

Comment thread test/helpers.cpp
@firewave firewave marked this pull request as draft April 11, 2024 10:22
@firewave
Copy link
Copy Markdown
Collaborator Author

Need to update this as it no longer compiles.

Will adjust the code noted.

@firewave
Copy link
Copy Markdown
Collaborator Author

Turns out it does compile. I had issues with a branched based off this but it might be an outdated repo.

@firewave firewave marked this pull request as ready for review April 11, 2024 10:25
Copy link
Copy Markdown
Collaborator

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit 423617a into cppcheck-opensource:main Apr 11, 2024
@firewave firewave deleted the directives branch April 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants