cleaned up access of the check classes

[firewave]

No description provided.

[firewave]

This highlights that (outside of testing) most of the implementations of the check do not need to be visible at all outside of their TU. This is what triggered me to start #5323.

[danmar]

Well I agree it would be ideal to encapsulate the check classes better in the normal cppcheck program. However I do not feel sure about this. friend is really ugly. There is the expression: "In C++, your friend can see your privates".

I see no ideal solution that people will not see problems with.

[firewave]

Well I agree it would be ideal to encapsulate the check classes better in the normal cppcheck program. However I do not feel sure about this. friend is really ugly. There is the expression: "In C++, your friend can see your privates".

I see no ideal solution that people will not see problems with.

The friend is only for test usage which is good. I will make further adjustments in follow-up PRs so they can be reduced/dropped in preparation of #5323.

[danmar]

The friend is only for test usage which is good.

Yeah I know, that is your intention. Any class that happens to have a certain name can see those privates, you don't technically enforce somehow that this is only used in testing.

I don't feel excited about adding friends. And well I don't feel totally excited about alternatives neither.

[firewave]

Any class that happens to have a certain name can see those privates, you don't technically enforce somehow that this is only used in testing.

Before it was public and anybody could have used the implementation stuff.

The code should not have friend declarations (we already have it in other places) but that requires tests (or even library code) to be refactored or even completely re-written. This at least gives an indication where there is work to do.

[danmar]

we can delay this refactoring until after the release at least.

[firewave]

we can delay this refactoring until after the release at least.

Fine with me.

[danmar]

well.. all I say is that I don't know any solution that I like. Let's do it this way if you think this is better.

[firewave]

well.. all I say is that I don't know any solution that I like. Let's do it this way if you think this is better.

You're gonna like #5435. 😃