Cross-platform CI matrix, Windows path tests, and PyInstaller smoke test (closes #44)#62
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR expands CI to run tests on Linux, Windows, and macOS; adds a Windows-only PyInstaller build + smoke-test; updates the launcher to parse CLI args passed from sys.argv; and adds win32-only normalize_file_path tests and a module docstring update. ChangesCross-Platform CI and Windows Desktop Build Verification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
tests/test_normalize_file_path.py:110 — test_percent_encoded_drive_on_win32 duplicates the win32 branch of test_percent_encoded_colon_in_uri_prefix (lines 60–63); consider dropping the new case or narrowing it to behavior not already asserted in TestNormalizeFilePathPercentEncoding. |
Closes #44
Summary
unittestCI matrix from Linux-only to ubuntu-latest, windows-latest, and macos-latest across Python 3.10–3.13, closing the cross-platform verification gap identified in eval test 27 / COMPOUND-D.--helpsmoke test on the Windows / Python 3.12 matrix cell so the desktop.exeis built and verified in CI without launching the GUI.TestNormalizeFilePathWindowsNative) that exercise drive letters, backslashes, andfile:///URIs on actual Windows runners.--helptolauncher.pyvia argparse so the PyInstaller bundle can be smoke-tested headlessly (help exits before pywebview is imported).Path duplication called out in #44 was already resolved in #46 —
scripts/export.pyimportsnormalize_file_pathfromutils.path_helpers.Test plan
dist/CursorChatBrowser/CursorChatBrowser.exeand passes--helpsmoke testTestNormalizeFilePathWindowsNativeruns (not skipped) onwindows-latest/tmp/fixture strings still pass on Windows/macOS (they are JSON literals, not filesystem paths)python -m unittest discover tests— 290 passed, 4 skippeddist/CursorChatBrowser/CursorChatBrowser.exe --help— exit 0Summary by CodeRabbit
New Features
Tests
Chores